grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org
Cc: Daniel Kiper <dkiper@net-space.pl>,
	Leo Sandoval <lsandova@redhat.com>,
	Andrew Hamilton <adhamilt@gmail.com>,
	Glenn Washburn <development@efficientek.com>
Subject: [PATCH 3/4] tests/erofs_test: Disable filetime check for erofs_compact
Date: Sat,  8 Nov 2025 21:20:09 -0600	[thread overview]
Message-ID: <208e7de8e67b38522a708490312d213c0a6fc781.1762657969.git.development@efficientek.com> (raw)
In-Reply-To: <cover.1762657969.git.development@efficientek.com>

Compact EROFS inodes do not allow for modification times that are
different from FS creation times. The file modification time check is
done between the EROFS image and the file system where test temporary
files are written to, not the files as seen from the mounted EROFS image.
So its likely that the file modification time will be different, more
so when run on slower systems.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 tests/util/grub-fs-tester.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in
index 37f54fabe8f1..579b937f5bc1 100644
--- a/tests/util/grub-fs-tester.in
+++ b/tests/util/grub-fs-tester.in
@@ -587,6 +587,10 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 1); do
 		# FS LIMITATION: romfs has no timestamps.
 		x"romfs")
 		    NOFILETIME=y; NOFSTIME=y;;
+		# FS LIMITATION: Compact inodes do not allow for modification
+		#   times that are different from FS creation times.
+		x"erofs_compact")
+		    NOFILETIME=y;;
 	    esac
 
 	    NOFSLABEL=n
-- 
2.34.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

  parent reply	other threads:[~2025-11-09  3:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-09  3:20 [PATCH 0/4] EROFS test fixes and improvements Glenn Washburn
2025-11-09  3:20 ` [PATCH 1/4] tests/erofs_test: Only test and set labels if supported by erofs-utils Glenn Washburn
2025-11-09  3:20 ` [PATCH 2/4] tests/erofs_test: Remove root check Glenn Washburn
2025-11-09  3:20 ` Glenn Washburn [this message]
2025-11-09  3:20 ` [PATCH 4/4] tests/erofs_test: Improve accuracy of FSTIME check Glenn Washburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=208e7de8e67b38522a708490312d213c0a6fc781.1762657969.git.development@efficientek.com \
    --to=development@efficientek.com \
    --cc=adhamilt@gmail.com \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=lsandova@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).