From: Vladimir Testov <vladimir.testov@rosalab.ru>
To: grub-devel@gnu.org
Subject: [1/4] [PATCH] circular progress bar: one tick is always missed
Date: Wed, 13 Mar 2013 14:51:50 +0400 [thread overview]
Message-ID: <2200963.rvgdJmOe3c@icedphoenix> (raw)
[-- Attachment #1: Type: text/plain, Size: 311 bytes --]
Number of printed ticks is always decreased by 1. (see screenshots)
num_ticks = 8
Before - current state.
After - after applying the patch.
Appear - ticks are appearing.
Disappear - ticks are disappearing.
--
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru
[-- Attachment #2: grub-guide-before-appear.png --]
[-- Type: image/png, Size: 2457 bytes --]
[-- Attachment #3: grub-guide-before-disappear.png --]
[-- Type: image/png, Size: 2357 bytes --]
[-- Attachment #4: grub-guide-after-appear.png --]
[-- Type: image/png, Size: 2490 bytes --]
[-- Attachment #5: grub-guide-after-disappear.png --]
[-- Type: image/png, Size: 2537 bytes --]
[-- Attachment #6: grub-2.00-unprinted-tick.patch --]
[-- Type: text/x-patch, Size: 578 bytes --]
diff -Naur grub-2.00/grub-core/gfxmenu/gui_circular_progress.c grub-new/grub-core/gfxmenu/gui_circular_progress.c
--- grub-2.00/grub-core/gfxmenu/gui_circular_progress.c 2010-12-01 17:45:43.000000000 +0300
+++ grub-new/grub-core/gfxmenu/gui_circular_progress.c 2013-03-11 12:52:06.993973802 +0400
@@ -152,12 +152,12 @@
if (self->ticks_disappear)
{
tick_begin = nticks;
- tick_end = self->num_ticks - 1;
+ tick_end = self->num_ticks;
}
else
{
tick_begin = 0;
- tick_end = nticks - 1;
+ tick_end = nticks;
}
int i;
reply other threads:[~2013-03-13 10:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2200963.rvgdJmOe3c@icedphoenix \
--to=vladimir.testov@rosalab.ru \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).