From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UDVWx-0002M5-4X for mharc-grub-devel@gnu.org; Thu, 07 Mar 2013 02:46:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDVWu-0002Lb-Ia for grub-devel@gnu.org; Thu, 07 Mar 2013 02:46:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDVWt-0000st-8X for grub-devel@gnu.org; Thu, 07 Mar 2013 02:46:20 -0500 Received: from collab.rosalab.ru ([217.199.216.181]:44934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDVWs-0000sg-ST for grub-devel@gnu.org; Thu, 07 Mar 2013 02:46:19 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by collab.rosalab.ru (Postfix) with ESMTP id EB11629C2EE for ; Thu, 7 Mar 2013 11:46:16 +0400 (MSK) X-Virus-Scanned: amavisd-new at rosalab.ru Received: from collab.rosalab.ru ([127.0.0.1]) by localhost (collab.rosalab.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KZ6t40ls-HW0 for ; Thu, 7 Mar 2013 11:46:16 +0400 (MSK) Received: from icedphoenix.localnet (unknown [10.168.1.56]) by collab.rosalab.ru (Postfix) with ESMTPSA id 57D2A29C2EC for ; Thu, 7 Mar 2013 11:46:16 +0400 (MSK) From: Vladimir Testov To: grub-devel@gnu.org Subject: Re: [PATCH] gfxterm: check elements' properties and hadle errors. Date: Thu, 07 Mar 2013 11:46:15 +0400 Message-ID: <2544568.Y50qHJl12c@icedphoenix> User-Agent: KMail/4.9.4 (Linux/3.5.0-23-generic; KDE/4.9.4; x86_64; ; ) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="nextPart2351708.dEoljbk0f7" Content-Transfer-Encoding: 7Bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 217.199.216.181 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2013 07:46:21 -0000 This is a multi-part message in MIME format. --nextPart2351708.dEoljbk0f7 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" >This is not a correct error handling. You should never return an error >without calling grub_error. Also in all these contexts you handle the >cases of unknown property name. I don't feel like refusing to load a >theme because of unknown property is a good idea. This would i.a. >exclude older GRUB versions for newer themes even if property in >question is minor in meaning. Compare this to a browser refusing to show >a page because of unknown tag attribute. Also GRUB_ERR_IO hardly >describes a condition of unknown property. Thanks for the reply. :) This subject is closed. -- With best regards, _______________________________ Vladimir Testov, ROSA Laboratory. www.rosalab.ru --nextPart2351708.dEoljbk0f7 Content-Transfer-Encoding: 7Bit Content-Type: text/html; charset="us-ascii" 
>This is not a correct error handling. You should never return an error
>without calling grub_error. Also in all these contexts you handle the
>cases of unknown property name. I don't feel like refusing to load a
>theme because of unknown property is a good idea. This would i.a.
>exclude older GRUB versions for newer themes even if property in
>question is minor in meaning. Compare this to a browser refusing to show
>a page because of unknown tag attribute. Also GRUB_ERR_IO hardly
>describes a condition of unknown property.
Thanks for the reply. :) This subject is closed.

--

With best regards,

_______________________________

Vladimir Testov, ROSA Laboratory.

www.rosalab.ru

--nextPart2351708.dEoljbk0f7--