grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: "Thomas Schmitt" <scdbackup@gmx.net>
To: grub-devel@gnu.org
Cc: arvidjaar@gmail.com
Subject: Re: About the CLI of both grub-mkrescue versions
Date: Fri, 10 Oct 2014 22:29:58 +0200	[thread overview]
Message-ID: <29560547187450858316@scdbackup.webframe.org> (raw)
In-Reply-To: <20141010221904.4a602eff@opensuse.site>

Hi,

> Well, below is much more simple patch which is reusing argp
> infrastructure. The only problem - it needs small patch for gnulib
> otherwise --help does not work. IMHO this is a bug in gnulib. If you
> convince them to fix it ...

Me ? I cannot even convince you or Vladimir :))

I understand that you propose a single interpretation mode
which shall be compatible with grub-mkrescue(.in) from
GRUB 2.00.
In the first thread about this topic, the wish was issued to
make the ISO producer behave like other GRUB tools.
Does any of them use ARGP_NO_ERRS ?

My proposal tries to keep old scripts runnable, while not
hampering the transition to the common interpretation style.
It also complains about now unsupported options of grub-mkrescue(.in),
wheras your poposal forwards them to xorriso. (If i get it right.)


> I do not say that I particular like it, but looks better than
> reimplement parser from scratch.

At least it addresses my concerns about compatibility for
scripts.

If it gets implemented, then it should catch old options
  -v
  --version
  --modules
  --modules= 
  --override-directory
  --override-directory=

My proposal for -vi and --version was:
        {
          printf ("%s %s %s\n", argv[0], PACKAGE_NAME, PACKAGE_VERSION);
          exit (0);
        }
The others just issue an error message and exit, as i do not
know whether they would make sense in grub-mkrescue.c.


Have a nice day :)

Thomas



  reply	other threads:[~2014-10-10 20:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23  8:12 About the CLI of both grub-mkrescue versions Thomas Schmitt
2014-09-28 16:17 ` Andrei Borzenkov
2014-09-28 16:52   ` Thomas Schmitt
2014-09-28 18:28     ` Thomas Schmitt
2014-09-29  5:04       ` Andrei Borzenkov
2014-09-29  7:07         ` Thomas Schmitt
2014-10-01  7:25           ` Thomas Schmitt
2014-10-10 18:19             ` Andrei Borzenkov
2014-10-10 20:29               ` Thomas Schmitt [this message]
2014-11-28 19:41             ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-11-29  5:38               ` Andrei Borzenkov
2014-11-29 10:55                 ` Thomas Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29560547187450858316@scdbackup.webframe.org \
    --to=scdbackup@gmx.net \
    --cc=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).