grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Testov <vladimir.testov@rosalab.ru>
To: grub-devel@gnu.org
Subject: Re: ticks_disappear option in circular_progress has no default value
Date: Fri, 08 Feb 2013 19:17:32 +0400	[thread overview]
Message-ID: <3264485.AOix8cDIaf@icedphoenix> (raw)

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

My last mesage about this problem wasn't answered.

Maybe I should write more detailed message.

There is parameter for circular progress bar, which hasn't a default value.

ticks_disappear

If it set to "0" in terms of source code ("true" in terms of grub2 theme) then 
ticks will APPEAR.
If it set to "1" in terms of source code ("false" in terms of grub2 theme) 
then ticks will DISAPPEAR.

Two patches are included for making some value to be default (grub2-ticks-
appear-default.patch and grub2-ticks-disappear-default.patch)

One of them should be used. (In current situations there is no default value 
and I see some kind of instability if none "ticks_disappear" was mentioned in 
a theme.)

Thanks. )

-- 
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru

[-- Attachment #2: grub2-ticks-appear-default.patch --]
[-- Type: text/x-patch, Size: 466 bytes --]

diff -Naur grub-new/grub-core/gfxmenu/gui_circular_progress.c grub-new2/grub-core/gfxmenu/gui_circular_progress.c
--- grub-new/grub-core/gfxmenu/gui_circular_progress.c	2010-12-01 17:45:43.000000000 +0300
+++ grub-new2/grub-core/gfxmenu/gui_circular_progress.c	2013-02-06 20:31:14.198825969 +0400
@@ -303,6 +303,7 @@
   self->visible = 1;
   self->num_ticks = 64;
   self->start_angle = -64;
+  self->ticks_disappear = 0;
 
   return (grub_gui_component_t) self;
 }

[-- Attachment #3: grub2-ticks-disappear-default.patch --]
[-- Type: text/x-patch, Size: 466 bytes --]

diff -Naur grub-new/grub-core/gfxmenu/gui_circular_progress.c grub-new2/grub-core/gfxmenu/gui_circular_progress.c
--- grub-new/grub-core/gfxmenu/gui_circular_progress.c	2010-12-01 17:45:43.000000000 +0300
+++ grub-new2/grub-core/gfxmenu/gui_circular_progress.c	2013-02-06 20:31:14.198825969 +0400
@@ -303,6 +303,7 @@
   self->visible = 1;
   self->num_ticks = 64;
   self->start_angle = -64;
+  self->ticks_disappear = 1;
 
   return (grub_gui_component_t) self;
 }

             reply	other threads:[~2013-02-08 15:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-08 15:17 Vladimir Testov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-02-06 16:35 ticks_disappear option in circular_progress has no default value Vladimir Testov
2013-02-26 20:50 ` Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3264485.AOix8cDIaf@icedphoenix \
    --to=vladimir.testov@rosalab.ru \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).