From: Christian Franke <Christian.Franke@t-online.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check
Date: Fri, 09 Nov 2007 22:53:23 +0100 [thread overview]
Message-ID: <4734D6D3.9020307@t-online.de> (raw)
In-Reply-To: <20071109205125.GA23437@thorin>
Robert Millan wrote:
> On Tue, Oct 23, 2007 at 09:06:16PM +0200, Christian Franke wrote:
>
>> +/* Check memory address */
>> +static int
>> +addr_is_valid (grub_addr_t addr)
>> +{
>> + volatile unsigned char * p = (volatile unsigned char *)addr;
>> + unsigned char x, y;
>> + x = *p;
>> + *p = x ^ 0xcf;
>> + y = *p;
>> + *p = x;
>> + return y == (x ^ 0xcf);
>> +}
>> +
>>
>
> I have a feeling this might be dangerous. Any comments on the warnings
> listed here:
>
> http://www.osdev.org/wiki/How_Do_I_Determine_The_Amount_Of_RAM#Counting_RAM_by_direct_probing
>
> ?
>
> Specially the bit about memory-mapped PCI.
>
This code does not check any memory-mapped PCI. It does only check the
boundary returned by the BIOS memory map evaluation code (which didn't
work in the E801 case).
Definitely not mandatory, but a IMO recommended assert-type check for
experimental code.
> Besides, if we really want it, perhaps it should be in a separate file so that
> other ports can use it if it's needed ?
>
Good point.
> Ah, and why 0xcf instead of 0xff ?
>
>
... or 0xaa or 0x55.
c.f. :-)
next prev parent reply other threads:[~2007-11-09 21:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 19:06 [PATCH] Fix eisa_mmap evaluation, add memory existence check Christian Franke
2007-10-23 20:18 ` Robert Millan
2007-10-23 20:36 ` Christian Franke
2007-11-09 14:17 ` Marco Gerards
2007-11-09 23:12 ` Christian Franke
2007-11-10 15:59 ` Marco Gerards
2007-11-10 19:53 ` Christian Franke
2007-11-09 20:51 ` Robert Millan
2007-11-09 21:53 ` Christian Franke [this message]
2007-11-09 22:51 ` Robert Millan
2007-11-18 11:09 ` Marco Gerards
2007-11-18 11:21 ` Robert Millan
2007-11-18 11:27 ` Robert Millan
2007-11-18 12:26 ` Robert Millan
2007-11-19 21:40 ` Christian Franke
2007-12-31 15:40 ` Christian Franke
2008-01-01 11:16 ` Robert Millan
2008-01-01 17:26 ` Christian Franke
2008-01-01 17:44 ` Robert Millan
2008-01-01 18:03 ` Christian Franke
2008-01-01 18:33 ` Robert Millan
2008-01-04 11:49 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4734D6D3.9020307@t-online.de \
--to=christian.franke@t-online.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox