From: Krzysztof Smiechowicz <deadwood@wp.pl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Corrections to affs and sfs
Date: Sat, 29 Nov 2008 09:27:51 +0100 [thread overview]
Message-ID: <4930FD07.4000107@wp.pl> (raw)
In-Reply-To: <20081128201408.GG7980@thorin>
Hello,
Robert Millan pisze:
>> Index: fs/sfs.c
>> ===================================================================
>> --- fs/sfs.c (revision 1919)
>> +++ fs/sfs.c (working copy)
>> @@ -172,7 +172,8 @@
>> return grub_errno;
>> }
>>
>> - for (i = 0; i < grub_be_to_cpu16 (tree->nodes); i++)
>> + grub_uint16_t nodescount = grub_be_to_cpu16(tree->nodes);
>> + for (i = nodescount - 1; i >= 0; i--)
>
> nodescount is only used once; why adding a variable?
No particular reason. Feel free to correct it :)
Best regards,
Krzysztof
next prev parent reply other threads:[~2008-11-29 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 19:55 [PATCH] Corrections to affs and sfs Krzysztof Smiechowicz
2008-11-28 20:14 ` Robert Millan
2008-11-29 8:27 ` Krzysztof Smiechowicz [this message]
2009-01-06 17:44 ` Krzysztof Smiechowicz
2009-02-07 20:33 ` Robert Millan
2009-02-11 19:39 ` Krzysztof Smiechowicz
-- strict thread matches above, loose matches on Subject: below --
2009-02-22 1:30 Kalamatee
2009-02-27 19:51 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4930FD07.4000107@wp.pl \
--to=deadwood@wp.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox