From: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [patch] incorrect root device while /dev/ on tmpfs
Date: Sat, 17 Oct 2009 15:39:50 +0200 [thread overview]
Message-ID: <4AD9C926.8030104@gmail.com> (raw)
In-Reply-To: <4AD9B795.6000201@parallels.com>
Vasily Averin wrote:
> While /dev mounted as tmpfs it does not contain /dev/disk/by-uuid directory,
> 10_linux script did not check it properly and do not set root device via UUID.
> Therefore following kernel boot can fail (incorrect root device) if device names
> was changed.
>
>
I would be inclined to say that for mainline presence of
/dev/disk/by-uuid is a reasonable indication that initrd supports root
specified by UUID. If it's not present then we should assume initrd is
dumb and doesn't recognises UUID= and just hardcode the device. The
distributors can modify it as they see fit.
> Attached path fixes this issue. Please review and commit it
>
> thank you,
> Vasily Averin
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
prev parent reply other threads:[~2009-10-17 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-17 12:24 [patch] incorrect root device while /dev/ on tmpfs Vasily Averin
2009-10-17 12:50 ` Felix Zielcke
2009-10-17 12:56 ` Colin Watson
2009-10-17 13:40 ` Felix Zielcke
2009-10-17 12:55 ` Colin Watson
2009-10-17 13:39 ` Vladimir 'phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD9C926.8030104@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox