From: "Grégoire Sutre" <gregoire.sutre@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Build error: "ENABLE_NLS" is not defined
Date: Wed, 20 Jan 2010 20:53:01 +0100 [thread overview]
Message-ID: <4B575F1D.3090601@gmail.com> (raw)
In-Reply-To: <20100119233811.GP8599@thorin>
Robert Millan wrote:
> This affects gnulib/error.c and gnulib/gettext.h which would be much better
> not to change, as they're being imported semi-automatically.
I understand.
But could this be actually a bug in gnulib? The problem only occurs
when gettext is not found and when compiling with -Wundef -Werror, so
maybe it went unnoticed?
> Perhaps you could solve this at its source? (i.e. by defining ENABLE_NLS to
> 0 when gettext is unavailable).
Indeed, the problem is gone when the following line is added before the
call to AM_GNU_GETTEXT in configure.ac:
AC_DEFINE([ENABLE_NLS], [0])
It does not really solve the problem at its source, though. ENABLE_NLS
is defined in AM_GNU_GETTEXT and the documentation of this macro [1]
does not require ENABLE_NLS to be defined when gettext is not available.
Best regards,
Grégoire
[1]
http://www.gnu.org/software/hello/manual/gettext/AM_005fGNU_005fGETTEXT.html
prev parent reply other threads:[~2010-01-20 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 18:52 Build error: "ENABLE_NLS" is not defined Grégoire Sutre
2010-01-12 19:09 ` richardvoigt
2010-01-12 19:31 ` Grégoire Sutre
2010-01-12 20:59 ` richardvoigt
2010-01-13 1:02 ` Grégoire Sutre
2010-01-19 23:38 ` Robert Millan
2010-01-20 19:53 ` Grégoire Sutre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B575F1D.3090601@gmail.com \
--to=gregoire.sutre@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox