Grub Development Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix Cygwin path handling
Date: Mon, 26 Apr 2010 08:56:24 +0200	[thread overview]
Message-ID: <4BD53918.9030609@gmail.com> (raw)
In-Reply-To: <4BD52EE8.5020403@t-online.de>

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

Christian Franke wrote:
> Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> Christian Franke wrote:
>>   
>>>      
>> +      /* Include leading slash.  */
>> +      offset = 0;
>> +      break;
>> Why do you make this change? It seems to make the behaviour of
>> make_path_relative_to_its root inconsistent since E.g.
>> /boot/grub ->  grub
>> /etc ->  /etc
>>    
>
> Could not reproduce. Old and new code always include the leading slash
> (except "/" -> ''").
>
I actually seen the '/' case and have incorrectly assumed it's always
so. However there is still one case when you patch changes the behaviour:
$ grub-mkrelpath /

$ ./grub-mkrelpath /
/
Although:
$ ./grub-mkrelpath /mnt/boot/

$ grub-mkrelpath /mnt/boot/


A simple filter at the end of make_path_relative_to_its_root is enough.
Just it's better to avoid both inconsistency between mountpoint and root
and behaviour change

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]

  reply	other threads:[~2010-04-26  6:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-14 18:36 [PATCH] Fix Cygwin path handling Christian Franke
2010-04-17 15:22 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-04-17 16:10   ` Christian Franke
2010-04-17 20:58     ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-04-19 14:49     ` BVK Chaitanya
2010-04-26  1:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-04-26  6:12   ` Christian Franke
2010-04-26  6:56     ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2010-04-26 10:18       ` Christian Franke
2010-05-01 19:40         ` Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD53918.9030609@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox