From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong?
Date: Mon, 07 Jun 2010 22:22:18 +0200 [thread overview]
Message-ID: <4C0D54FA.3060200@gmail.com> (raw)
In-Reply-To: <20100607165842.GL21862@riva.ucam.org>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On 06/07/2010 06:58 PM, Colin Watson wrote:
> While writing documentation for booting GRUB over the network, I noticed
> that the code to handle (pxe:server_ip:gateway_ip) device names looks
> wrong. Shouldn't it be like this?
>
>
Go ahead.
> 2010-06-07 Colin Watson <cjwatson@ubuntu.com>
>
> * fs/i386/pc/pxe.c (grub_pxe_open): Fix parsing of gateway_ip.
>
> === modified file 'fs/i386/pc/pxe.c'
> --- fs/i386/pc/pxe.c 2010-02-14 12:18:33 +0000
> +++ fs/i386/pc/pxe.c 2010-06-07 16:56:22 +0000
> @@ -114,7 +114,7 @@ grub_pxe_open (const char *name, grub_di
> return err;
> if (*ptr == ':')
> {
> - err = parse_ip (ptr + 1, &(data->server_ip), 0);
> + err = parse_ip (ptr + 1, &(data->gateway_ip), 0);
> if (err)
> return err;
> }
>
> Thanks,
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2010-06-07 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 16:58 [PATCH] (pxe:server_ip:gateway_ip) parsing wrong? Colin Watson
2010-06-07 20:18 ` Colin Watson
2010-06-07 21:02 ` Seth Goldberg
2010-06-07 20:22 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0D54FA.3060200@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox