Grub Development Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [Patch] Use absolute offset for embedding area in grub-setup (i386-pc)
Date: Mon, 07 Jun 2010 22:48:06 +0200	[thread overview]
Message-ID: <4C0D5B06.8000209@gmail.com> (raw)
In-Reply-To: <4C0998AC.5010405@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 901 bytes --]

On 06/05/2010 02:22 AM, Grégoire Sutre wrote:
> Hi,
>
> The attached patch uses grub_partition_get_start (p) instead of p->start
> in grub-setup's iteration over partitions.  While we are at it, also
> use grub_partition_get_len (p) instead of p->len.
Go ahead
>
> An alternative would be to assume that partitions are properly nested,
> and therefore iterate only over the top-level ones (i.e. those with
> p->parent == NULL).  In that case, we could equivalently use p->start.
>
>
> In the check for non-empty embedding area, the patch uses <= instead of
> == (as we may have embed_region.start == 1 && embed_region.end == 0).
>
> Comments?
>
> Grégoire
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


[-- Attachment #1.2: Type: text/html, Size: 1678 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

      reply	other threads:[~2010-06-07 20:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-05  0:22 [Patch] Use absolute offset for embedding area in grub-setup (i386-pc) Grégoire Sutre
2010-06-07 20:48 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C0D5B06.8000209@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox