From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Oz5ep-0004bb-Op for mharc-grub-devel@gnu.org; Fri, 24 Sep 2010 06:37:35 -0400 Received: from [140.186.70.92] (port=45291 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oz5el-0004O5-Uy for grub-devel@gnu.org; Fri, 24 Sep 2010 06:37:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oz5eS-0005Ib-89 for grub-devel@gnu.org; Fri, 24 Sep 2010 06:37:13 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:62961) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oz5eS-0005IT-3F for grub-devel@gnu.org; Fri, 24 Sep 2010 06:37:12 -0400 Received: by wwb24 with SMTP id 24so2851264wwb.30 for ; Fri, 24 Sep 2010 03:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=MvM5/C+9jOT6gJaUVjEOdNmyJn0PnIHb4haNvyI0744=; b=dfqh2W2RDOWaBCAoX/KtDHT7V13bIEFBxMwa7emak0RHDtSxMDHib6FDPZxdtgPp64 CzcwpHsaGygxCWPoBDmDIdVCSXP1m9Zdokz0P8KfVIUyrJt1UTVexfC4uP09ag/VDn3+ HUzIrXgl8zjV3JwtYagvItZxe/nvtd/426d1g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=ATwvvlgKqe2TfzGOuYqKcufq/5z22/XQuyv9OMoTyaWUELXOKHK7V3QIygrtQp7oSg iDcEiJv1MCbmwRO766WJ6b/dViDmxv0ZmYd4UPY56IdlbR9sZTozUHRpkpl5djSGHT5O LESMb8ODe8sJgSL+29wf68HfsVOl+0AXZCBNk= Received: by 10.227.157.70 with SMTP id a6mr2646876wbx.163.1285324630543; Fri, 24 Sep 2010 03:37:10 -0700 (PDT) Received: from [147.210.129.4] (laptop-147-210-129-4.labri.fr [147.210.129.4]) by mx.google.com with ESMTPS id g9sm1653140wbh.19.2010.09.24.03.37.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 24 Sep 2010 03:37:09 -0700 (PDT) Message-ID: <4C9C7F53.8070409@gmail.com> Date: Fri, 24 Sep 2010 12:37:07 +0200 From: =?ISO-8859-1?Q?Gr=E9goire_Sutre?= User-Agent: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.9.1.11) Gecko/20100723 Lightning/1.0b2pre Shredder/3.0.6 MIME-Version: 1.0 To: grub-devel@gnu.org References: <4C9B3BD0.3060108@gmail.com> <20100924101858.GG21862@riva.ucam.org> In-Reply-To: <20100924101858.GG21862@riva.ucam.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Fix getline name clash X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Sep 2010 10:37:34 -0000 On 09/24/2010 12:18, Colin Watson wrote: > This looks good to me as far as it goes, but doesn't it need a bit more? I guess we should not rename the actual calls to the getline() library function (otherwise gnulib's replacement won't help). And I personally don't mind if function arguments and local variables are substituted. But I agree that, in general, it would be safer to avoid names that might be inadvertently replaced by gnulib's #defines. Grégoire