From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1P1aAK-0000RV-Vk for mharc-grub-devel@gnu.org; Fri, 01 Oct 2010 03:36:25 -0400 Received: from [140.186.70.92] (port=45045 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P1aAE-0000Qc-7R for grub-devel@gnu.org; Fri, 01 Oct 2010 03:36:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P1aAD-00082i-3s for grub-devel@gnu.org; Fri, 01 Oct 2010 03:36:18 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:62689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P1aAC-00082V-VW for grub-devel@gnu.org; Fri, 01 Oct 2010 03:36:17 -0400 Received: by fxm10 with SMTP id 10so2474962fxm.0 for ; Fri, 01 Oct 2010 00:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=l3UmmnAiJPWrJq7FBrtvdajNtYa/ydAVqtycvSRPgek=; b=CNTZsgQY3eqGzFvZi59izWfQvNdntVA8/Knf92tfWi32Bwcburg4Wlq+fd5oT0pnJD otZITQOXDAgcwBQrUBNd9AC/MLO4sFGcLWHWwzatcbUA58749dANE44KWI7B/TS2AowU h5yzkWj+oh5D+jN4KnW8hg4F6YPolePs6jvog= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=pQACHtLZKqoZ9RbPWcsr952cwz9s1KDud/pv00p514JH5tS+mzSpJlBgQbqUJl8Y7v Y/6q6ZeLvZTuGXwjITpHwC9fHW98V+NB3SaJFE7v7DsClisJ3N7dStQUlzG79pDw7Ylc 10xWZoPylzaffHiWQO6tEkdjCqWE/Wko+Ksik= Received: by 10.223.124.208 with SMTP id v16mr3962753far.54.1285918576072; Fri, 01 Oct 2010 00:36:16 -0700 (PDT) Received: from debian.yeeloong.phnet (public-docking-hg-2-026.ethz.ch [129.132.247.26]) by mx.google.com with ESMTPS id r10sm429392faq.5.2010.10.01.00.36.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 01 Oct 2010 00:36:13 -0700 (PDT) Message-ID: <4CA58F52.4040404@gmail.com> Date: Fri, 01 Oct 2010 09:35:46 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux mips64; en-US; rv:1.9.1.12) Gecko/20100918 Icedove/3.0.8 MIME-Version: 1.0 To: grub-devel@gnu.org References: <20100921183525.GP21862@riva.ucam.org> <20100923130819.GV21862@riva.ucam.org> <1285273648.6015.30.camel@pracovna> In-Reply-To: <1285273648.6015.30.camel@pracovna> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Trunk: usbtrans.c - wrong max packet size for bulk transfer X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Oct 2010 07:36:20 -0000 On 09/23/2010 10:27 PM, Aleš Nesrsta wrote: > code works on on 64 bits architectures. */ > - u->td = (grub_uhci_td_t) grub_memalign (4096, 4096*2); > + u->td = (grub_uhci_td_t) grub_memalign (4096, 32*N_TD); > if (! u->td) > goto fail; > Could you use sizeof while on it? - endpdesc = grub_usb_get_endpdescriptor (dev, 0); + endpdesc = grub_usb_get_endpdescriptor (dev, endpoint); It's hard to see the context of this change. Could you use --diff-options=-p in the future? Other than that this patch is ok for trunk -- Regards Vladimir 'φ-coder/phcoder' Serbinenko