From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Trunk: usbtrans.c - wrong max packet size for bulk transfer
Date: Fri, 01 Oct 2010 20:33:08 +0200 [thread overview]
Message-ID: <4CA62964.2000402@gmail.com> (raw)
In-Reply-To: <1285945650.6460.15.camel@pracovna>
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
On 10/01/2010 05:07 PM, Aleš Nesrsta wrote:
> Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>
>> On 09/23/2010 10:27 PM, Aleš Nesrsta wrote:
>>
>>> code works on on 64 bits architectures. */
>>> - u->td = (grub_uhci_td_t) grub_memalign (4096, 4096*2);
>>> + u->td = (grub_uhci_td_t) grub_memalign (4096, 32*N_TD);
>>> if (! u->td)
>>> goto fail;
>>>
>>>
>> Could you use sizeof while on it?
>>
>> - endpdesc = grub_usb_get_endpdescriptor (dev, 0);
>> + endpdesc = grub_usb_get_endpdescriptor (dev, endpoint);
>> It's hard to see the context of this change. Could you use --diff-options=-p in the future?
>> Other than that this patch is ok for trunk
>>
> Hi,
> there is corrected patch (with sizeof and -p) for review before going to
> trunk.
> Regards
> Ales
>
>
Go ahead
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2010-10-01 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 18:35 [PATCH] Re-enable grub-extras Colin Watson
2010-09-23 13:08 ` Colin Watson
2010-09-23 13:12 ` Colin Watson
2010-09-23 14:23 ` Colin Watson
2010-09-23 14:36 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-09-24 9:09 ` Colin Watson
2010-09-23 20:27 ` [PATCH] Trunk: usbtrans.c - wrong max packet size for bulk transfer Aleš Nesrsta
2010-10-01 7:35 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-10-01 15:07 ` Aleš Nesrsta
2010-10-01 18:33 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2010-10-02 18:58 ` Aleš Nesrsta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA62964.2000402@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).