From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1P1lYJ-0000Zx-4p for mharc-grub-devel@gnu.org; Fri, 01 Oct 2010 15:45:55 -0400 Received: from [140.186.70.92] (port=33284 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P1klL-0002sr-SS for grub-devel@gnu.org; Fri, 01 Oct 2010 14:55:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P1kQD-0006td-01 for grub-devel@gnu.org; Fri, 01 Oct 2010 14:34:23 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:58464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P1kQC-0006tM-Qm for grub-devel@gnu.org; Fri, 01 Oct 2010 14:33:28 -0400 Received: by bwz10 with SMTP id 10so3295907bwz.0 for ; Fri, 01 Oct 2010 11:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=aEhEWBFliWPqvnQTkDAV1RUHVn0dsRM2l3pfoVdHi7U=; b=yDUjgjZhk4HlKTIWKO4DOPSHwYq6OmC+wI+pIfe7pfR1IeXoedHX/zVfpNXkhaGav9 5ex6xZUkz5G0Bj3xZo6F+fonVvSrrelNuT/A4/eNQ9fib+VZrWFYhG/zESdcQdnoCqbB ueLT12JsxdtsWgaPWAgI9ZYaC3yYPOlfXt2R0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=UuCAok9LxVrBkw1JAh/ACZG1NnlU4CDOXeBOUhVeoQqyXrEVB/Idkvp0ojeLri39Yq mu7JZsO6KY5ZJ6aLHUzTkreRTSXPsOWt4I4sZP/pau2VtS+6STJbI86mdghA1r33YDom R8LQcBhpUiXj+dTic967pm1KY/pXW/bec8++A= Received: by 10.204.122.206 with SMTP id m14mr4294429bkr.61.1285958007814; Fri, 01 Oct 2010 11:33:27 -0700 (PDT) Received: from debian.bg45.phnet (156-70.203-62.cust.bluewin.ch [62.203.70.156]) by mx.google.com with ESMTPS id s34sm1190769bkk.1.2010.10.01.11.33.25 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 01 Oct 2010 11:33:26 -0700 (PDT) Message-ID: <4CA62964.2000402@gmail.com> Date: Fri, 01 Oct 2010 20:33:08 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Icedove/3.0.6 MIME-Version: 1.0 To: grub-devel@gnu.org References: <20100921183525.GP21862@riva.ucam.org> <20100923130819.GV21862@riva.ucam.org> <1285273648.6015.30.camel@pracovna> <4CA58F52.4040404@gmail.com> <1285945650.6460.15.camel@pracovna> In-Reply-To: <1285945650.6460.15.camel@pracovna> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigF5590654EC678C855D0D6853" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Trunk: usbtrans.c - wrong max packet size for bulk transfer X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Oct 2010 19:45:53 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF5590654EC678C855D0D6853 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/01/2010 05:07 PM, Ale=C5=A1 Nesrsta wrote: > Vladimir '=CF=86-coder/phcoder' Serbinenko wrote:=20 > =20 >> On 09/23/2010 10:27 PM, Ale=C5=A1 Nesrsta wrote: >> =20 >>> code works on on 64 bits architectures. */ >>> - u->td =3D (grub_uhci_td_t) grub_memalign (4096, 4096*2); >>> + u->td =3D (grub_uhci_td_t) grub_memalign (4096, 32*N_TD); >>> if (! u->td) >>> goto fail; >>> =20 >>> =20 >> Could you use sizeof while on it? >> >> - endpdesc =3D grub_usb_get_endpdescriptor (dev, 0); >> + endpdesc =3D grub_usb_get_endpdescriptor (dev, endpoint); >> It's hard to see the context of this change. Could you use --diff-opti= ons=3D-p in the future? >> Other than that this patch is ok for trunk >> =20 > Hi, > there is corrected patch (with sizeof and -p) for review before going t= o > trunk. > Regards > Ales > > =20 Go ahead > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigF5590654EC678C855D0D6853 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkymKXQACgkQNak7dOguQglOmwD9E/dZm04q5X36MVBMHnFHPU66 peGhghv4pQ7LWhzfP/AA/3n4ZudGh+o3YIgIGjVYgJKwKgANaq0r+FTwDxWVDQKd =vpLF -----END PGP SIGNATURE----- --------------enigF5590654EC678C855D0D6853--