From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1P1lIX-0008Ux-2C for mharc-grub-devel@gnu.org; Fri, 01 Oct 2010 15:29:37 -0400 Received: from [140.186.70.92] (port=44394 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P1kl2-0002BF-M9 for grub-devel@gnu.org; Fri, 01 Oct 2010 14:55:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P1kTo-0007tH-Cy for grub-devel@gnu.org; Fri, 01 Oct 2010 14:37:17 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:45721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P1kTo-0007t2-7r for grub-devel@gnu.org; Fri, 01 Oct 2010 14:37:12 -0400 Received: by fxm10 with SMTP id 10so2951812fxm.0 for ; Fri, 01 Oct 2010 11:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=PcqSChdoODFm17MHT0X9bwO+J5cTvHbuSRaV8qc4nOo=; b=Vtxr9NroJmY7hg0aSd1NNg9w9RpQiTW821JWDqG08RuLk7lepzYp8GgrxOtor72fRu wSxAy4wCrof4fIHwJLky6UkToXhVdkKygdzf6zeyowxs0BKeiRZLuIUqQGNu1z7uvqop MjJ1SCimUk6qK3R37yndkg5lCN50yjeo36f8k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=cWo0ajdb3ufOFe9AfRTEEAN3uhp5ASpq5EnkRJnSxPvUHodklYRSxgeEJAKJZPq6iZ IbkoSXt0AQcEMKlX9yTRJOrfyl26EcO3K6FdWZRUv3NgG7zt5r0HtI5Rcppuvuu0DNLn F+75ivLNq6Q/9Yr4HMDi7suTC1nkiWJS05f30= Received: by 10.223.114.19 with SMTP id c19mr5989244faq.29.1285958231306; Fri, 01 Oct 2010 11:37:11 -0700 (PDT) Received: from debian.bg45.phnet (156-70.203-62.cust.bluewin.ch [62.203.70.156]) by mx.google.com with ESMTPS id b11sm795371faq.30.2010.10.01.11.37.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 01 Oct 2010 11:37:04 -0700 (PDT) Message-ID: <4CA62A4E.5090008@gmail.com> Date: Fri, 01 Oct 2010 20:37:02 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Icedove/3.0.6 MIME-Version: 1.0 To: grub-devel@gnu.org References: <1285531907.4545.9.camel@pracovna> <4CA4FC38.8000308@gmail.com> <1285945596.6460.14.camel@pracovna> In-Reply-To: <1285945596.6460.14.camel@pracovna> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig57E0C97A9CA523EF32CF55D6" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] USB Mass Storage CBI support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Oct 2010 19:29:35 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig57E0C97A9CA523EF32CF55D6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/01/2010 05:06 PM, Ale=C5=A1 Nesrsta wrote: > Vladimir '=CF=86-coder/phcoder' Serbinenko wrote:=20 > =20 >> On 09/26/2010 10:11 PM, Ale=C5=A1 Nesrsta wrote: >> =20 >>> + grub_uint8_t cbicb[GRUB_USBMS_CBI_CMD_SIZE] =3D >>> + { 0x1d, 0x04, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, >>> + 0xff, 0xff >>> + }; >>> =20 >>> =20 >> Could you deblob this? >> Other that this it can be merged into experimental. Be sure to push >> branches/cbi and then merge branches/cbi into experimental >> =20 > Hi, > > I am sorry, but I don't know what is "deblob", my English language > knowledge is unfortunately little bit limited (as you probably noticed > before...)... > =20 In the context of GNU it means not to use an incomprehensible sequence of integers and replace it with something more readable, e.g. structure definition or defines. > (My dictionary says: "blob" is "small amount of a thick liquid"...) > > I guess you probably want to explain what the code means and add relate= d > comment (?) > > It is CBI specific command "Command Block Reset" which should be used t= o > reset CBI protocol in "phase error" or similar fatal cases, i.e. it is > something like "Bulk Only Reset" control command. > There is difference between BO and CBI style of device communication > reset: > "Bulk Only Reset" is class-specific request for Bulk Only Mass Storage > devices. > CBI "Command Block Reset" is sent to device as a command block, i.e. as= > DATA of CBI class-specific "universal" request ADSC. > (In both cases should be additionally cleared HALT feature on all EPs -= > except control EP 0.) > > In "USB Mass Storage Class Control/Bulk/Interrupt (CBI) Transport" > specification > (http://www.usb.org/developers/devclass_docs/usb_msc_cbi_1.1.pdf) you > can find "Command Block Reset" in chapter 2.2 Command Block Reset > Protocol, there is part of specification (citation): > > "... To issue a Command Block Reset, the host shall use the Non-Data > Command Protocol to transport the command block: > 1Dh 04h FFh FFh FFh FFh ... > The device may use the trailing FFh bytes to distinguish the Command > Block Reset from the legacy op 1Dh SEND DIAGNOSTIC command block. > ..." > > Regards > Ales=20 > =20 >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> http://lists.gnu.org/mailman/listinfo/grub-devel >> =20 > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig57E0C97A9CA523EF32CF55D6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkymKk4ACgkQNak7dOguQgmRwAD+LkM/YwOoBPocZvCWN7FpDYd1 B6MgCa7BYJOloB2sK3QA/iG6Ccr1CdFR9hPP17FZFLf5xbnpm9RtC8FoFMZ0RLqO =E9ZA -----END PGP SIGNATURE----- --------------enig57E0C97A9CA523EF32CF55D6--