Re: [PATCH] fix load of RHEL ans SUSE images by correctly calculate ELF entry point

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2200 bytes --]

On 11/04/2010 04:04 PM, Manoel Rebelo Abranches wrote:
> Fixed some issues reported by Vladimir:
>
> Initial alignment value 1 instead of 0.
> Verify error by returning address being -1 since 0 may be valid in
> memory allocated directly by the Open Firmware.
> Use 'end' instead of (addr + len) to search for available memory.
> change hardcoded value '1' to GRUB_MEMORY_AVAILABLE.
>
Go ahead.
> On 10/19/2010 11:46 AM, Manoel Rebelo Abraches wrote:
>> This is another version to the same fix.
>>
>> The first patch 01_mem.patch creates a new function to allocate memory
>> using the "available" property in the "memory" node.
>> The second patch 02_offset.patch correctly finds the linux entry point,
>> also assumes that more segments can exist (made accordingly with sparc
>> implementation)
>>
>> The patch was made passing  -Bbp to diff as suggested by Vladimir.
>> I tested with RHEL/SUSE images and some RHEL/SUSE kernel I had and
>> worked correctly. Before the images failed to boot.
>> Thank you for reviewing this.
>>
>> On Mon, 2010-09-27 at 04:29 -0300, Manoel Rebelo Abraches wrote:
>>> This Patch loads kernel LOAD segment at the address fixed by PhysAddr
>>> with alignment Align at the ELF program header. Even if this address is
>>> in use other address with the same alignment is found "linuxadr" (since
>>> linux can relocate itself). The linux main function is then find in the
>>> adress linuxaddr + entry + (PhysAddr- Entry), where Entry is  the Entry
>>> point address in the ELF header. (PhysAddr- Entry) gives the offset
>>> where the linux entry point is located after linuxaddr.
>>>
>>>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> Grub-devel@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]