From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1PLFZC-0007Nr-40 for mharc-grub-devel@gnu.org; Wed, 24 Nov 2010 08:39:22 -0500 Received: from [140.186.70.92] (port=41603 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLFYt-0007Gj-Jb for grub-devel@gnu.org; Wed, 24 Nov 2010 08:39:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLFYf-0003u3-3w for grub-devel@gnu.org; Wed, 24 Nov 2010 08:39:03 -0500 Received: from mail-gw0-f41.google.com ([74.125.83.41]:33513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLFYe-0003tm-Vj for grub-devel@gnu.org; Wed, 24 Nov 2010 08:38:49 -0500 Received: by gwj16 with SMTP id 16so92553gwj.0 for ; Wed, 24 Nov 2010 05:38:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=vsWyQ8Eq2Mq9DiY5lo0EI5sdPGvsi3uzg2jMMWZ0T6Y=; b=LvKShs8r19R/MFsuok9MaWrPT4fVWK3sKKgz352jc8nE/YQj0M58HDDONqyzwDrF4h LRkz+HWn6lnhaKzW6fZdin455vV2tO8qAHHMDN9HFqE3kXgEzME/8CvN+SuAhRaJ46WA BWR+hLRrGqIC7PL1Kyp3W7WydSstwNvw11l+M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=U1s5aIIoHYQQhK1BDfFbmYF5C9wyFTFMcBw0h8EyvLwZeHIHJiBwhN8ra+XiiSEPWL CQjyarlpvHqgknduRwNA+ntsQK+UDwWhX/j1QB+B8i594y4BZMubGsszob5dGY8OL5UN lzGIBDpKBu3dSleIRHguWSxgkTYKU1ng10Qlg= Received: by 10.204.62.73 with SMTP id w9mr8664051bkh.48.1290605910944; Wed, 24 Nov 2010 05:38:30 -0800 (PST) Received: from debian.bg45.phnet (public-docking-hg-2-103.ethz.ch [129.132.247.103]) by mx.google.com with ESMTPS id d12sm3739676bkw.19.2010.11.24.05.38.29 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 24 Nov 2010 05:38:29 -0800 (PST) Message-ID: <4CED154E.2020800@gmail.com> Date: Wed, 24 Nov 2010 14:38:22 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101030 Icedove/3.0.10 MIME-Version: 1.0 To: grub-devel@gnu.org References: <20101123162113.GG21862@riva.ucam.org> <20101124120849.GA10958@riva.ucam.org> In-Reply-To: <20101124120849.GA10958@riva.ucam.org> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigB3ECEB648FC156E1543F9BB4" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: powerpc/emu build failure X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2010 13:39:20 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB3ECEB648FC156E1543F9BB4 Content-Type: multipart/mixed; boundary="------------090306040203000201000907" This is a multi-part message in MIME format. --------------090306040203000201000907 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/24/2010 01:08 PM, Colin Watson wrote: > On Tue, Nov 23, 2010 at 04:21:14PM +0000, Colin Watson wrote: > =20 >> It seems to me that we should probably include the emu implementation = of >> grub_arch_sync_caches in the kernel when building for the emu platform= =2E >> Does this patch look sane? >> >> 2010-11-23 Colin Watson >> >> * grub-core/Makefile.core.def (kernel): Add kern/emu/cache.S for emu >> platforms. >> (grub-emu-lite): Remove kern/emu/cache.S. >> =20 > I went ahead and committed this; Manoel Rebelo Abranches seemed keen on= > IRC, and it certainly doesn't break anything on x86 since the object is= > essentially empty there. > > =20 Could you try the attached patch as a replacement for yours? Not that your patch doesn't solve the problem but it's more annoying for maintenan= ce. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------090306040203000201000907 Content-Type: text/x-diff; name="endian.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="endian.diff" =3D=3D=3D modified file 'include/grub/gpt_partition.h' --- include/grub/gpt_partition.h 2009-04-19 20:38:46 +0000 +++ include/grub/gpt_partition.h 2010-11-23 17:33:09 +0000 @@ -36,7 +36,7 @@ } =20 #define GRUB_GPT_PARTITION_TYPE_BIOS_BOOT \ - { grub_cpu_to_le32 (0x21686148), grub_cpu_to_le16 (0x6449), grub_cpu_t= o_le16 (0x6e6f), \ + { grub_cpu_to_le32_compile_time (0x21686148), grub_cpu_to_le16_compile= _time (0x6449), grub_cpu_to_le16_compile_time (0x6e6f), \ { 0x74, 0x4e, 0x65, 0x65, 0x64, 0x45, 0x46, 0x49 } \ } =20 =3D=3D=3D modified file 'include/grub/types.h' --- include/grub/types.h 2010-10-26 10:29:12 +0000 +++ include/grub/types.h 2010-11-23 17:32:43 +0000 @@ -146,6 +146,9 @@ (grub_uint16_t) ((_x << 8) | (_x >> 8)); \ }) =20 +#define grub_swap_bytes16_compile_time(x) ((((x) & 0xff) << 8) | (((x) &= 0xff00) >> 8)) +#define grub_swap_bytes32_compile_time(x) ((((x) & 0xff) << 24) | (((x) = & 0xff00) << 8) | (((x) & 0xff0000) >> 8) | (((x) & 0xff000000) >> 24)) + #if defined(__GNUC__) && (__GNUC__ > 3) && (__GNUC__ > 4 || __GNUC_MINOR= __ >=3D 3) static inline grub_uint32_t grub_swap_bytes32(grub_uint32_t x) { @@ -193,6 +196,8 @@ # define grub_be_to_cpu16(x) ((grub_uint16_t) (x)) # define grub_be_to_cpu32(x) ((grub_uint32_t) (x)) # define grub_be_to_cpu64(x) ((grub_uint64_t) (x)) +# define grub_cpu_to_le32_compile_time(x) grub_swap_bytes32_compile_time= (x) +# define grub_cpu_to_le16_compile_time(x) grub_swap_bytes16_compile_time= (x) #else /* ! WORDS_BIGENDIAN */ # define grub_cpu_to_le16(x) ((grub_uint16_t) (x)) # define grub_cpu_to_le32(x) ((grub_uint32_t) (x)) @@ -206,6 +211,8 @@ # define grub_be_to_cpu16(x) grub_swap_bytes16(x) # define grub_be_to_cpu32(x) grub_swap_bytes32(x) # define grub_be_to_cpu64(x) grub_swap_bytes64(x) +# define grub_cpu_to_le16_compile_time(x) ((grub_uint16_t) (x)) +# define grub_cpu_to_le32_compile_time(x) ((grub_uint32_t) (x)) #endif /* ! WORDS_BIGENDIAN */ =20 #endif /* ! GRUB_TYPES_HEADER */ --------------090306040203000201000907-- --------------enigB3ECEB648FC156E1543F9BB4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkztFU4ACgkQNak7dOguQgnKrgD+M3RF5uSvd038NvF8rPd72dzJ d1ecVNhg6x1kUX+kZyABAJIXAarpSNWP9SjwKOeO2E7zEXjAgvW2kkJ637wGSWc2 =uT2x -----END PGP SIGNATURE----- --------------enigB3ECEB648FC156E1543F9BB4--