From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Execute menu editor commands with argument scope
Date: Sat, 18 Dec 2010 16:31:41 +0100 [thread overview]
Message-ID: <4D0CD3DD.9040402@gmail.com> (raw)
In-Reply-To: <AANLkTinW14RHKdZ++uN-pjnUnFmUGBjKMFOHkLZ360j+@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
On 12/08/2010 12:32 PM, BVK Chaitanya wrote:
> Hi,
>
>
> Jordan_U pointed out that setparams command doesn't work when a
> menuentry is executed through menu editor; that is, using Ctrl-x.
> This is because menu editor commands execute as individual commands,
> outside function/menuentry scopes. So setparams command does not work
> as expected.
>
>
> Attached patch fixes this issue by executing menu editor commands with a scope.
>
>
patch is ok. Go ahead for mainline. (if you can connect to savannah /-: )
>
>
> bvk.chaitanya
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2010-12-18 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 11:32 [PATCH] Execute menu editor commands with argument scope BVK Chaitanya
2010-12-18 15:31 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0CD3DD.9040402@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).