From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1PYfed-0003Fb-SS for mharc-grub-devel@gnu.org; Fri, 31 Dec 2010 09:08:27 -0500 Received: from [140.186.70.92] (port=50705 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PYfeb-0003FW-H1 for grub-devel@gnu.org; Fri, 31 Dec 2010 09:08:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PYfeZ-0000HZ-WC for grub-devel@gnu.org; Fri, 31 Dec 2010 09:08:25 -0500 Received: from mail-wy0-f169.google.com ([74.125.82.169]:50561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PYfeZ-0000HU-Ru for grub-devel@gnu.org; Fri, 31 Dec 2010 09:08:23 -0500 Received: by wyj26 with SMTP id 26so12200615wyj.0 for ; Fri, 31 Dec 2010 06:08:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=6gTVZ2IPGAEaARPH/mh00caArSomKiyzuCzNgUUYSSU=; b=OGXgqsAoQ4tO21GQOlgFldmvfXn/7ajzIrYkTBtoGCCMAVIQpgYjW2adK98CKQswxD 2L4lOnUIrULi+gWjXe5MH0Vg0yxhcNfgIwQQH4sgCIjt9lNcp/0OqmVsMcbYBUOq7iph YY9uow0hjeUclB6ZTsHNRx4bLiBA3Q87HD3+I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=q6XiCSeBVTnLSGmE9G/hrm6W63uH4f37hvPO2Yfb/JbyQYLWi2fq4OuTPFjcqvkp6D WimZlMTC4AR1joxKh93dsQgfAF0Tnz9qObLAiejMLld11lGvF7EmfVOgPBB/m+3cWIDz cr2+er8+z5UUF6MB3gbJjJdfO2MYS4yo/P+3o= Received: by 10.216.229.4 with SMTP id g4mr7876569weq.54.1293804503058; Fri, 31 Dec 2010 06:08:23 -0800 (PST) Received: from debian.bg45.phnet (76-57.203-62.cust.bluewin.ch [62.203.57.76]) by mx.google.com with ESMTPS id p49sm7187028wes.18.2010.12.31.06.08.21 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 31 Dec 2010 06:08:22 -0800 (PST) Message-ID: <4D1DE3CC.4040909@gmail.com> Date: Fri, 31 Dec 2010 15:08:12 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101226 Icedove/3.0.11 MIME-Version: 1.0 To: grub-devel@gnu.org References: <201012300629.oBU6TcSp022378@m5p.com> In-Reply-To: <201012300629.oBU6TcSp022378@m5p.com> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig163877F7E03407F89AE4C263" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Small Bug in grub-core/partmap/amiga.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Dec 2010 14:08:26 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig163877F7E03407F89AE4C263 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/30/2010 07:29 AM, ehem+grub@m5p.com wrote: > Alas, AmigaOS has mostly passed beyond the veil, but one can still find= > small bugs sometimes: > =20 BTW, Amiga partmap and filesystems support in GRUB is for AROS, not Amiga= =2E > =3D=3D=3D modified file 'grub-core/partmap/amiga.c' > --- grub-core/partmap/amiga.c 2010-03-26 14:44:13 +0000 > +++ grub-core/partmap/amiga.c 2010-12-30 06:25:26 +0000 > @@ -87,7 +87,7 @@ > if (grub_disk_read (disk, pos, 0, sizeof (rdsk), &rdsk)) > return grub_errno; > =20 > - if (grub_strcmp ((char *) rdsk.magic, "RDSK") =3D=3D 0) > + if (grub_strncmp ((char *) rdsk.magic, "RDSK", sizeof(rdsk.magic= )) =3D=3D 0) > { > /* Found the first PART block. */ > next =3D grub_be_to_cpu32 (rdsk.partitionlst); > > > I both like and dislike using strcmp() for this purpose. I kind of like= > keeping it as a string, but strcmp()... Anyway, minimal solution. > > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig163877F7E03407F89AE4C263 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk0d48wACgkQNak7dOguQgnxrAD/ZqL0PVaqAYiUTDlBTe56aI++ OdvMMEvz+4AWtkrmax8BAMPEHjzuQASCth7xwGDUK+Pvzbbv8JYGQHMVQaTFA1X3 =I431 -----END PGP SIGNATURE----- --------------enig163877F7E03407F89AE4C263--