From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: terminfo test regression
Date: Thu, 06 Jan 2011 14:15:47 +0100 [thread overview]
Message-ID: <4D25C083.5090308@gmail.com> (raw)
In-Reply-To: <20110106131007.GP15515@riva.ucam.org>
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
On 01/06/2011 02:10 PM, Colin Watson wrote:
> Hi Vladimir,
>
> Your terminfo_cls change has regressed 'make check', because now all the
> shell output has \e[H\e[J in front of it. How do you want to go about
> fixing that? This looks plausible and passes the tests:
>
> 2011-01-06 Colin Watson <cjwatson@ubuntu.com>
>
> * tests/util/grub-shell.in: Set serial terminfo type to `dumb', to
> avoid causing test failures by clearing the screen.
>
>
Go ahead.
> === modified file 'tests/util/grub-shell.in'
> --- tests/util/grub-shell.in 2010-12-23 11:51:18 +0000
> +++ tests/util/grub-shell.in 2011-01-06 13:06:25 +0000
> @@ -119,6 +119,7 @@ cat <<EOF >${cfgfile}
> grubshell=yes
> insmod serial
> serial
> +terminfo serial dumb
> terminal_input serial
> terminal_output serial
> EOF
>
> Thanks,
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2011-01-06 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 13:10 terminfo test regression Colin Watson
2011-01-06 13:15 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D25C083.5090308@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).