* terminfo test regression
@ 2011-01-06 13:10 Colin Watson
2011-01-06 13:15 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 2+ messages in thread
From: Colin Watson @ 2011-01-06 13:10 UTC (permalink / raw)
To: grub-devel
Hi Vladimir,
Your terminfo_cls change has regressed 'make check', because now all the
shell output has \e[H\e[J in front of it. How do you want to go about
fixing that? This looks plausible and passes the tests:
2011-01-06 Colin Watson <cjwatson@ubuntu.com>
* tests/util/grub-shell.in: Set serial terminfo type to `dumb', to
avoid causing test failures by clearing the screen.
=== modified file 'tests/util/grub-shell.in'
--- tests/util/grub-shell.in 2010-12-23 11:51:18 +0000
+++ tests/util/grub-shell.in 2011-01-06 13:06:25 +0000
@@ -119,6 +119,7 @@ cat <<EOF >${cfgfile}
grubshell=yes
insmod serial
serial
+terminfo serial dumb
terminal_input serial
terminal_output serial
EOF
Thanks,
--
Colin Watson [cjwatson@ubuntu.com]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: terminfo test regression
2011-01-06 13:10 terminfo test regression Colin Watson
@ 2011-01-06 13:15 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2011-01-06 13:15 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
On 01/06/2011 02:10 PM, Colin Watson wrote:
> Hi Vladimir,
>
> Your terminfo_cls change has regressed 'make check', because now all the
> shell output has \e[H\e[J in front of it. How do you want to go about
> fixing that? This looks plausible and passes the tests:
>
> 2011-01-06 Colin Watson <cjwatson@ubuntu.com>
>
> * tests/util/grub-shell.in: Set serial terminfo type to `dumb', to
> avoid causing test failures by clearing the screen.
>
>
Go ahead.
> === modified file 'tests/util/grub-shell.in'
> --- tests/util/grub-shell.in 2010-12-23 11:51:18 +0000
> +++ tests/util/grub-shell.in 2011-01-06 13:06:25 +0000
> @@ -119,6 +119,7 @@ cat <<EOF >${cfgfile}
> grubshell=yes
> insmod serial
> serial
> +terminfo serial dumb
> terminal_input serial
> terminal_output serial
> EOF
>
> Thanks,
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-06 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-06 13:10 terminfo test regression Colin Watson
2011-01-06 13:15 ` Vladimir 'φ-coder/phcoder' Serbinenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).