Build failure on NetBSD

Build failure on NetBSD

[Grégoire Sutre]

Hi,

Trunk does not build on NetBSD (it's 5.99.41 in case that matters).

$ (./autogen.sh ; ./configure ; gmake) > /tmp/grub-build.log 2>&1

gives, at the end of the log:

grub-core/kern/emu/hostdisk.c:102:27: error: libdevmapper.h: No such file or 
directory
grub-core/kern/emu/misc.c:46:27: error: libdevmapper.h: No such file or 
directory
gmake: *** [libgrub.pp] Error 1

Grégoire

Re: Build failure on NetBSD

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

On 01/06/2011 06:41 PM, Grégoire Sutre wrote:
> Hi,
>
> Trunk does not build on NetBSD (it's 5.99.41 in case that matters).
>
> $ (./autogen.sh ; ./configure ; gmake) > /tmp/grub-build.log 2>&1
>
> gives, at the end of the log:
>
> grub-core/kern/emu/hostdisk.c:102:27: error: libdevmapper.h: No such
> file or directory
> grub-core/kern/emu/misc.c:46:27: error: libdevmapper.h: No such file
> or directory
> gmake: *** [libgrub.pp] Error 1
>
This means that HAVE_DEVICE_MAPPER is defined. It shouldn't be. Can you
post config.log?
> Grégoire
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

Re: Build failure on NetBSD

[Grégoire Sutre]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

On 01/06/2011 18:51, Vladimir 'φ-coder/phcoder' Serbinenko wrote:

> This means that HAVE_DEVICE_MAPPER is defined. It shouldn't be. Can you
> post config.log?

Seems like this log requires compression to go through...

Grégoire

[-- Attachment #2: config.log.gz --]
[-- Type: application/x-gzip, Size: 51025 bytes --]

Re: Build failure on NetBSD

[Grégoire Sutre]

On 01/06/2011 18:51, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> This means that HAVE_DEVICE_MAPPER is defined. It shouldn't be. Can you
> post config.log?

(Too big for the list.)

http://pastebin.com/YnFzxHKP

Grégoire

Re: Build failure on NetBSD

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

On 01/06/2011 07:18 PM, Grégoire Sutre wrote:
> On 01/06/2011 18:51, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> This means that HAVE_DEVICE_MAPPER is defined. It shouldn't be. Can you
>> post config.log?
>
> (Too big for the list.)
>
> http://pastebin.com/YnFzxHKP
>
Looks like you actualy do have libdevmapper (I'm surprised it exists for
NetBSD) but not the headers. We should check for headers too.

> Grégoire
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

Re: Build failure on NetBSD

[Grégoire Sutre]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

> Looks like you actualy do have libdevmapper (I'm surprised it exists for
> NetBSD) but not the headers.

I'm not sure what it's for (I don't use LVM).  The utility dmsetup(8)
(ported from Linux?) requires it.

 > We should check for headers too.

Attached patch adds this.

Grégoire

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: devmapper-header-check.diff --]
[-- Type: text/x-patch; name="devmapper-header-check.diff", Size: 940 bytes --]

=== modified file 'ChangeLog'
--- ChangeLog	2011-01-06 13:24:38 +0000
+++ ChangeLog	2011-01-06 21:27:31 +0000
@@ -1,3 +1,7 @@
+2011-01-06  Grégoire Sutre  <gregoire.sutre@gmail.com>
+
+	* configure.ac: Check for libdevmapper header.
+
 2011-01-06  Colin Watson  <cjwatson@ubuntu.com>
 
 	* tests/util/grub-shell.in: Set serial terminfo type to `dumb', to

=== modified file 'configure.ac'
--- configure.ac	2010-11-16 15:50:20 +0000
+++ configure.ac	2011-01-06 21:31:21 +0000
@@ -867,6 +867,12 @@ if test x"$enable_device_mapper" = xno ;
 fi
 
 if test x"$device_mapper_excuse" = x ; then
+  # Check for device-mapper header.
+  AC_CHECK_HEADER([libdevmapper.h], [],
+               [device_mapper_excuse="need libdevmapper header"])
+fi
+
+if test x"$device_mapper_excuse" = x ; then
   # Check for device-mapper library.
   AC_CHECK_LIB([devmapper], [dm_task_create], [],
                [device_mapper_excuse="need devmapper library"])

Re: Build failure on NetBSD

[Grégoire Sutre]

On 01/06/2011 19:18, Grégoire Sutre wrote:
> On 01/06/2011 18:51, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> This means that HAVE_DEVICE_MAPPER is defined. It shouldn't be. Can you
>> post config.log?

On this system, there is a /lib/libdevmapper.so but no libdevmapper.h.
Afaics, configure does not check for libdevmapper.h.

Grégoire

Re: Build failure on NetBSD

[Colin Watson]

On Thu, Jan 06, 2011 at 06:41:28PM +0100, Grégoire Sutre wrote:
> Trunk does not build on NetBSD (it's 5.99.41 in case that matters).
>
> $ (./autogen.sh ; ./configure ; gmake) > /tmp/grub-build.log 2>&1
>
> gives, at the end of the log:
>
> grub-core/kern/emu/hostdisk.c:102:27: error: libdevmapper.h: No such file 
> or directory
> grub-core/kern/emu/misc.c:46:27: error: libdevmapper.h: No such file or  
> directory
> gmake: *** [libgrub.pp] Error 1

Can you post a configure log?  This indicates that HAVE_DEVICE_MAPPER
was defined by configure.

-- 
Colin Watson                                       [cjwatson@ubuntu.com]