From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: devkral <devkral@web.de>, The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: encrypted partitions aren't recognized in a good way
Date: Thu, 21 Jul 2011 21:51:39 +0200 [thread overview]
Message-ID: <4E28834B.9020200@gmail.com> (raw)
In-Reply-To: <1311277164.1790.12.camel@archal>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
Please keep the list CC'ed.
On 21.07.2011 21:39, devkral wrote:
> sorry, I don't understand the uuid-LUKS logic of grub-probe and dmsetup
> doesn't support this check.
dmsetup info /dev/mapper/mycrypt gives:
...
UUID: CRYPT-LUKS1-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-mycrypt_unformatted
And with grub-probe -t cryptodisk_uuid /mnt/crypt
you have:
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Where xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx is the unique UUID which is also
used in /dev/disk/by-uuid/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx, just
formatted differently.
The patch as is unnecessarily uses a heavily different codepath than
non-crypt ones. From maintainance point of view this is unacceptable.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2011-07-21 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1311164827.2359.13.camel@archal>
2011-07-20 14:49 ` encrypted partitions aren't recognized in a good way Vladimir 'φ-coder/phcoder' Serbinenko
[not found] ` <1311277164.1790.12.camel@archal>
2011-07-21 19:51 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
[not found] ` <1311463612.1769.4.camel@archal>
2011-07-24 0:26 ` Vladimir 'φ-coder/phcoder' Serbinenko
[not found] ` <1311508112.14473.4.camel@archal>
2011-07-24 12:10 ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-11-10 8:58 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E28834B.9020200@gmail.com \
--to=phcoder@gmail.com \
--cc=devkral@web.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).