From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1QjzI0-0000GY-6j for mharc-grub-devel@gnu.org; Thu, 21 Jul 2011 15:52:08 -0400 Received: from eggs.gnu.org ([140.186.70.92]:43394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjzHv-0000AW-Nd for grub-devel@gnu.org; Thu, 21 Jul 2011 15:52:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjzHu-0007bI-JN for grub-devel@gnu.org; Thu, 21 Jul 2011 15:52:03 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:33767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjzHu-0007bA-D7 for grub-devel@gnu.org; Thu, 21 Jul 2011 15:52:02 -0400 Received: by wyg36 with SMTP id 36so1316170wyg.0 for ; Thu, 21 Jul 2011 12:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=lu46wTqm4FArIjrIFCNA21lxWh+OOsSd0StRTJD6B8A=; b=EfSI0DWorO0JIg4zyZWXwYuBrnGIM/a5TzWVQ6D8t0lapk57k3k823Es7+ADF4H91d CMtE70vAsMMigKVxZi6BDbdXMgA9zZRfSki6fLq6/Qn80g5PFBu5XXPbedPQFWHmqfx+ d9u9ryFbIdRBNaWn9yB20FLyfUBiNpB/koReY= Received: by 10.216.202.9 with SMTP id c9mr1139322weo.14.1311277921252; Thu, 21 Jul 2011 12:52:01 -0700 (PDT) Received: from debian.x201.phnet (25-138.203-62.cust.bluewin.ch [62.203.138.25]) by mx.google.com with ESMTPS id r48sm1085298weq.2.2011.07.21.12.51.54 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Jul 2011 12:52:00 -0700 (PDT) Message-ID: <4E28834B.9020200@gmail.com> Date: Thu, 21 Jul 2011 21:51:39 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Iceowl/1.0b2 Icedove/3.1.11 MIME-Version: 1.0 To: devkral , The development of GRUB 2 Subject: Re: encrypted partitions aren't recognized in a good way References: <1311164827.2359.13.camel@archal> <4E26EB0E.4040903@gmail.com> <1311277164.1790.12.camel@archal> In-Reply-To: <1311277164.1790.12.camel@archal> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigE4A6B28A54400B4C20BE30B2" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2011 19:52:04 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE4A6B28A54400B4C20BE30B2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Please keep the list CC'ed. On 21.07.2011 21:39, devkral wrote: > sorry, I don't understand the uuid-LUKS logic of grub-probe and dmsetup= > doesn't support this check. dmsetup info /dev/mapper/mycrypt gives: =2E.. UUID: CRYPT-LUKS1-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-mycrypt_unformatted And with grub-probe -t cryptodisk_uuid /mnt/crypt you have: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx Where xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx is the unique UUID which is also used in /dev/disk/by-uuid/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx, just formatted differently. The patch as is unnecessarily uses a heavily different codepath than non-crypt ones. From maintainance point of view this is unacceptable. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigE4A6B28A54400B4C20BE30B2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk4og0sACgkQNak7dOguQgmf7QD/fGZkDkPlod5P4GTvci3WS54b d62AYBHC3g/iK0uID5cA/iu8Z7+6JK1BOYEwHcuz9I1Xvgo2Tcz1T0oQdXiuexe8 =6R7X -----END PGP SIGNATURE----- --------------enigE4A6B28A54400B4C20BE30B2--