From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1QkxWO-0003JK-NS for mharc-grub-devel@gnu.org; Sun, 24 Jul 2011 08:11:00 -0400 Received: from eggs.gnu.org ([140.186.70.92]:42136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkxWL-0003JD-Of for grub-devel@gnu.org; Sun, 24 Jul 2011 08:10:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkxWK-00061k-9G for grub-devel@gnu.org; Sun, 24 Jul 2011 08:10:57 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:63253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkxWK-00061e-2c for grub-devel@gnu.org; Sun, 24 Jul 2011 08:10:56 -0400 Received: by wyg36 with SMTP id 36so2791962wyg.0 for ; Sun, 24 Jul 2011 05:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=a4cCx6qbnA88oM3y9MCq2N9v/GRLTf0yUQsnM2tLaSs=; b=E3K5BOqr6v9YKKZfCpWmv87bZh1mlIyoemAfbzwzAWOun4VKrqrkB11CDeedbTxoJS QbqMIsYsY8MIzUd5gwXcCya3Yr3pQl+jvG25DY0Tlcy2FtrE7gkBmxgTyLPfGayoc6KU yvkFWovY3HbSRKEJ8laH9M3gg58cfUhDu05Yg= Received: by 10.227.134.136 with SMTP id j8mr2963402wbt.42.1311509454810; Sun, 24 Jul 2011 05:10:54 -0700 (PDT) Received: from debian.x201.phnet (141-65.203-62.cust.bluewin.ch [62.203.65.141]) by mx.google.com with ESMTPS id gg16sm3457400wbb.0.2011.07.24.05.10.51 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 24 Jul 2011 05:10:53 -0700 (PDT) Message-ID: <4E2C0BC8.4050604@gmail.com> Date: Sun, 24 Jul 2011 14:10:48 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Iceowl/1.0b2 Icedove/3.1.11 MIME-Version: 1.0 To: devkral , The development of GRUB 2 Subject: Re: encrypted partitions aren't recognized in a good way References: <1311164827.2359.13.camel@archal> <4E26EB0E.4040903@gmail.com> <1311277164.1790.12.camel@archal> <4E28834B.9020200@gmail.com> <1311508112.14473.4.camel@archal> In-Reply-To: <1311508112.14473.4.camel@archal> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig82DE2699D097D80EAF823D6E" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jul 2011 12:10:58 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig82DE2699D097D80EAF823D6E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 24.07.2011 13:48, devkral wrote: > Am Donnerstag, den 21.07.2011, 21:51 +0200 schrieb Vladimir > '=CF=86-coder/phcoder' Serbinenko: >> Please keep the list CC'ed. Keep the list CC'ed. Idon't accept patches sent privately >> On 21.07.2011 21:39, devkral wrote: >>> sorry, I don't understand the uuid-LUKS logic of grub-probe and dmset= up >>> doesn't support this check. >> dmsetup info /dev/mapper/mycrypt gives: >> ... >> UUID: CRYPT-LUKS1-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-mycrypt_unformatted= >> And with grub-probe -t cryptodisk_uuid /mnt/crypt >> you have: >> xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx >> Where xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx is the unique UUID which is als= o >> used in /dev/disk/by-uuid/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx, just >> formatted differently. >> The patch as is unnecessarily uses a heavily different codepath than >> non-crypt ones. From maintainance point of view this is unacceptable. >> > I have had a logical mistake in my patch (the ':' doesn't vanish like > dmsetup =E2=80=A6 -c -o vg_name). Here the corrected version of my patc= h. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig82DE2699D097D80EAF823D6E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk4sC8gACgkQNak7dOguQglyaQD+KxN9MW8kTk2o6zIBwaoyVbzg xgsmuJViH2cMcSvgYoIBAJHj9f3zp6Y4u2iRm4IVpJHUp1bRBnJBqlJMYWrKhd0o =/Dpw -----END PGP SIGNATURE----- --------------enig82DE2699D097D80EAF823D6E--