From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Reset grub_errno after embedding test on non-fatal failures
Date: Mon, 26 Sep 2011 22:32:46 +0200 [thread overview]
Message-ID: <4E80E16E.8070607@gmail.com> (raw)
In-Reply-To: <4E80E041.5050503@dell.com>
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
On 26.09.2011 22:27, Mario Limonciello wrote:
> - return GRUB_ERR_NONE;
> + return grub_error(GRUB_ERR_NONE,"");
This is obviously the wrong place. It's the successful return clause. if
grub_errno isn't 0 at this point then the code is wrong somewhere else.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2011-09-26 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 20:27 [PATCH] Reset grub_errno after embedding test on non-fatal failures Mario Limonciello
2011-09-26 20:32 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2011-09-27 19:38 ` Seth Goldberg
2011-11-08 14:36 ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-09-27 19:39 ` (Subject on previous email) Seth Goldberg
2011-09-28 21:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E80E16E.8070607@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).