From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1R8HrP-0007Vl-UN for mharc-grub-devel@gnu.org; Mon, 26 Sep 2011 16:33:07 -0400 Received: from eggs.gnu.org ([140.186.70.92]:45785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8HrL-0007RN-Ki for grub-devel@gnu.org; Mon, 26 Sep 2011 16:33:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R8HrK-0004Ns-IA for grub-devel@gnu.org; Mon, 26 Sep 2011 16:33:03 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:33574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8HrK-0004No-Dr for grub-devel@gnu.org; Mon, 26 Sep 2011 16:33:02 -0400 Received: by wwp14 with SMTP id 14so5483665wwp.30 for ; Mon, 26 Sep 2011 13:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=jquUxSHjihxpPfahhCjsoUczqtZiYhA1vHFhdsTmbyE=; b=yGGB/jVHdszDe1AcH1Lzsjfn4M1CYwn9dx+L79HzVB+u9TyZM53SVpzgUuB1EPICg9 ZmvMAX+zv36sx0IpvzAHeqRpC+NnDUhYuTQwVF5XtvxGdNkFtjYBa7GQFNGSD3RIRJQG 81lUK+fdDEqmAF6M8YnxGd3QvHbB/Sjz0Q2qg= Received: by 10.227.20.6 with SMTP id d6mr7710345wbb.49.1317069180847; Mon, 26 Sep 2011 13:33:00 -0700 (PDT) Received: from debian.x201.phnet (gprs49.swisscom-mobile.ch. [193.247.250.49]) by mx.google.com with ESMTPS id l40sm18132167wbm.10.2011.09.26.13.32.56 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 26 Sep 2011 13:32:57 -0700 (PDT) Message-ID: <4E80E16E.8070607@gmail.com> Date: Mon, 26 Sep 2011 22:32:46 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Iceowl/1.0b2 Icedove/3.1.13 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] Reset grub_errno after embedding test on non-fatal failures References: <4E80E041.5050503@dell.com> In-Reply-To: <4E80E041.5050503@dell.com> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig3B6BEC111068F2293914C4E3" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.49 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2011 20:33:04 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3B6BEC111068F2293914C4E3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 26.09.2011 22:27, Mario Limonciello wrote: > - return GRUB_ERR_NONE; > + return grub_error(GRUB_ERR_NONE,""); This is obviously the wrong place. It's the successful return clause. if grub_errno isn't 0 at this point then the code is wrong somewhere else. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig3B6BEC111068F2293914C4E3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk6A4XcACgkQNak7dOguQgmkDQD/cqOc+9F4pRMvynD59Jjun1/L 3TjBAt65NqvKyG7SKs4A/3Ku8S3MkDih6rY8/3IqsTxKzwBtzAxaIP/fwrvDqJyG =YNUJ -----END PGP SIGNATURE----- --------------enig3B6BEC111068F2293914C4E3--