grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
* Add prefix option to grub-mkconfig
@ 2011-08-22 18:02 KESHAV P.R.
  2011-09-16  6:17 ` KESHAV P.R.
  2011-10-13 21:29 ` Jamie Kitson
  0 siblings, 2 replies; 15+ messages in thread
From: KESHAV P.R. @ 2011-08-22 18:02 UTC (permalink / raw)
  To: grub-devel

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Hi,
     I made a small change to grub-mkconfig.in script to add
GRUB_PREFIX option as an argument so that a single grub-mkconfig can
be used to generate grub.cfg for both /boot/grub (with bios video
modules being loaded) and /boot/efi/efi/grub (uefi video modules
loaded in the config). Please review and apply it. Thanks in advance.

Regards.

Keshav

PS: Patch attached.

[-- Attachment #2: grub-mkconfig-add-prefix-option.patch --]
[-- Type: text/x-patch, Size: 815 bytes --]

diff --git a/util/grub-mkconfig.in b/util/grub-mkconfig.in
index e317279..a457b26 100644
--- a/util/grub-mkconfig.in
+++ b/util/grub-mkconfig.in
@@ -49,6 +49,7 @@ usage () {
 Usage: $self [OPTION]
 Generate a grub config file
 
+  -p, --prefix=PATH       grub prefix dir [default=/boot/grub]
   -o, --output=FILE       output generated config to FILE [default=stdout]
   -h, --help              print this message and exit
   -v, --version           print the version information and exit
@@ -81,6 +82,11 @@ do
     -v | --version)
 	echo "$self (${PACKAGE_NAME}) ${PACKAGE_VERSION}"
 	exit 0 ;;
+    -p | --prefix)
+	GRUB_PREFIX=`argument $option "$@"`; shift;;
+    --prefix=*)
+	GRUB_PREFIX=`echo "$option" | sed "s,//*,/,g"`
+	;;
     -o | --output)
 	grub_cfg=`argument $option "$@"`; shift;;
     --output=*)

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-08-22 18:02 Add prefix option to grub-mkconfig KESHAV P.R.
@ 2011-09-16  6:17 ` KESHAV P.R.
  2011-09-16 17:18   ` Seth Goldberg
  2011-10-13 21:29 ` Jamie Kitson
  1 sibling, 1 reply; 15+ messages in thread
From: KESHAV P.R. @ 2011-09-16  6:17 UTC (permalink / raw)
  To: grub-devel

On Mon, Aug 22, 2011 at 23:32, KESHAV P.R. <skodabenz@gmail.com> wrote:
> Hi,
>     I made a small change to grub-mkconfig.in script to add
> GRUB_PREFIX option as an argument so that a single grub-mkconfig can
> be used to generate grub.cfg for both /boot/grub (with bios video
> modules being loaded) and /boot/efi/efi/grub (uefi video modules
> loaded in the config). Please review and apply it. Thanks in advance.
>
> Regards.
>
> Keshav
>
> PS: Patch attached.
>

Bump...


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-09-16  6:17 ` KESHAV P.R.
@ 2011-09-16 17:18   ` Seth Goldberg
  0 siblings, 0 replies; 15+ messages in thread
From: Seth Goldberg @ 2011-09-16 17:18 UTC (permalink / raw)
  To: The development of GNU GRUB

Looks good and is a desirable feature IMHO :).

On Sep 15, 2011, at 11:17 PM, "KESHAV P.R." <skodabenz@gmail.com> wrote:

> On Mon, Aug 22, 2011 at 23:32, KESHAV P.R. <skodabenz@gmail.com> wrote:
>> Hi,
>>     I made a small change to grub-mkconfig.in script to add
>> GRUB_PREFIX option as an argument so that a single grub-mkconfig can
>> be used to generate grub.cfg for both /boot/grub (with bios video
>> modules being loaded) and /boot/efi/efi/grub (uefi video modules
>> loaded in the config). Please review and apply it. Thanks in advance.
>> 
>> Regards.
>> 
>> Keshav
>> 
>> PS: Patch attached.
>> 
> 
> Bump...
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-08-22 18:02 Add prefix option to grub-mkconfig KESHAV P.R.
  2011-09-16  6:17 ` KESHAV P.R.
@ 2011-10-13 21:29 ` Jamie Kitson
  2011-10-26 20:44   ` Keshav P R
  1 sibling, 1 reply; 15+ messages in thread
From: Jamie Kitson @ 2011-10-13 21:29 UTC (permalink / raw)
  To: grub-devel

I was about to report this as an issue too.

Jamie



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-10-13 21:29 ` Jamie Kitson
@ 2011-10-26 20:44   ` Keshav P R
  2011-10-26 20:48     ` Seth Goldberg
  0 siblings, 1 reply; 15+ messages in thread
From: Keshav P R @ 2011-10-26 20:44 UTC (permalink / raw)
  To: The development of GNU GRUB

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

Hi all,
        As discussed in #grub irc, I think going the --boot-directory way as
phcoder suggested will lead to unnecessary complexity. I would prefer
directly mentioning the path to grub_prefix dir, as in case of uefi installs
the prefix dir could be anything (/efi/grub, /efi/grub2, /efi/grub_custom,
/efi/redhat, /efi/ubuntu etc.). Using --boot-directory in such a case also
requires --bootloader-id etc. to be provided.
       Proper GRUB_PREFIX is required for video.lst and locale_dir setting
in grub.cfg. The patch with --prefix option is at
http://pastie.org/2763921. Please give your views.

Regards.

Keshav

[-- Attachment #2: Type: text/html, Size: 709 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-10-26 20:44   ` Keshav P R
@ 2011-10-26 20:48     ` Seth Goldberg
  2011-10-26 20:54       ` Keshav P R
  0 siblings, 1 reply; 15+ messages in thread
From: Seth Goldberg @ 2011-10-26 20:48 UTC (permalink / raw)
  To: The development of GNU GRUB

Hi,

  Personally, I'd love to see boot-directory go away also -- I think you should 
be able to specify the exact directory you want without worrying about /grub 
being appended.  Same goes for mkconfig.

   --S

Quoting Keshav P R, who wrote the following on Thu, 27 Oct 2011:

> Hi all,
>        As discussed in #grub irc, I think going the --boot-directory way as
> phcoder suggested will lead to unnecessary complexity. I would prefer
> directly mentioning the path to grub_prefix dir, as in case of uefi installs
> the prefix dir could be anything (/efi/grub, /efi/grub2, /efi/grub_custom,
> /efi/redhat, /efi/ubuntu etc.). Using --boot-directory in such a case also
> requires --bootloader-id etc. to be provided.
>       Proper GRUB_PREFIX is required for video.lst and locale_dir setting
> in grub.cfg. The patch with --prefix option is at
> http://pastie.org/2763921. Please give your views.
>
> Regards.
>
> Keshav
>


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-10-26 20:48     ` Seth Goldberg
@ 2011-10-26 20:54       ` Keshav P R
  2011-10-26 21:04         ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 1 reply; 15+ messages in thread
From: Keshav P R @ 2011-10-26 20:54 UTC (permalink / raw)
  To: The development of GNU GRUB

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

On Thu, Oct 27, 2011 at 02:18, Seth Goldberg <seth.goldberg@oracle.com>wrote:

> Hi,
>
>  Personally, I'd love to see boot-directory go away also -- I think you
> should be able to specify the exact directory you want without worrying
> about /grub being appended.  Same goes for mkconfig.
>
>  --S
>
>
Yes, that would be best and gives direct control to the user. For now
GRUB_PREFIX denotes that final dir (atleast in the scripts).

- Keshav


>
> Quoting Keshav P R, who wrote the following on Thu, 27 Oct 2011:
>
>  Hi all,
>>       As discussed in #grub irc, I think going the --boot-directory way as
>> phcoder suggested will lead to unnecessary complexity. I would prefer
>> directly mentioning the path to grub_prefix dir, as in case of uefi
>> installs
>> the prefix dir could be anything (/efi/grub, /efi/grub2, /efi/grub_custom,
>> /efi/redhat, /efi/ubuntu etc.). Using --boot-directory in such a case also
>> requires --bootloader-id etc. to be provided.
>>      Proper GRUB_PREFIX is required for video.lst and locale_dir setting
>> in grub.cfg. The patch with --prefix option is at
>> http://pastie.org/2763921. Please give your views.
>>
>> Regards.
>>
>> Keshav
>>
>>
> ______________________________**_________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/**listinfo/grub-devel<https://lists.gnu.org/mailman/listinfo/grub-devel>
>

[-- Attachment #2: Type: text/html, Size: 2313 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-10-26 20:54       ` Keshav P R
@ 2011-10-26 21:04         ` Vladimir 'φ-coder/phcoder' Serbinenko
  2011-10-26 21:07           ` Seth Goldberg
  0 siblings, 1 reply; 15+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2011-10-26 21:04 UTC (permalink / raw)
  To: grub-devel

[-- Attachment #1: Type: text/plain, Size: 2010 bytes --]

On 26.10.2011 22:54, Keshav P R wrote:
> On Thu, Oct 27, 2011 at 02:18, Seth Goldberg <seth.goldberg@oracle.com
> <mailto:seth.goldberg@oracle.com>> wrote:
>
>     Hi,
>
>      Personally, I'd love to see boot-directory go away also -- I
>     think you should be able to specify the exact directory you want
>     without worrying about /grub being appended.  Same goes for mkconfig.
>
>      --S
>
>
> Yes, that would be best and gives direct control to the user. For now
> GRUB_PREFIX denotes that final dir (atleast in the scripts).
>
Ok, I open directory you specifiec without thinking too much and spill
loads of files in it. Happy sorting.
> - Keshav
>  
>
>
>     Quoting Keshav P R, who wrote the following on Thu, 27 Oct 2011:
>
>         Hi all,
>               As discussed in #grub irc, I think going the
>         --boot-directory way as
>         phcoder suggested will lead to unnecessary complexity. I would
>         prefer
>         directly mentioning the path to grub_prefix dir, as in case of
>         uefi installs
>         the prefix dir could be anything (/efi/grub, /efi/grub2,
>         /efi/grub_custom,
>         /efi/redhat, /efi/ubuntu etc.). Using --boot-directory in such
>         a case also
>         requires --bootloader-id etc. to be provided.
>              Proper GRUB_PREFIX is required for video.lst and
>         locale_dir setting
>         in grub.cfg. The patch with --prefix option is at
>         http://pastie.org/2763921. Please give your views.
>
>         Regards.
>
>         Keshav
>
>
>     _______________________________________________
>     Grub-devel mailing list
>     Grub-devel@gnu.org <mailto:Grub-devel@gnu.org>
>     https://lists.gnu.org/mailman/listinfo/grub-devel
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-10-26 21:04         ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2011-10-26 21:07           ` Seth Goldberg
  2011-10-26 21:14             ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 1 reply; 15+ messages in thread
From: Seth Goldberg @ 2011-10-26 21:07 UTC (permalink / raw)
  To: The development of GNU GRUB

[-- Attachment #1: Type: TEXT/PLAIN, Size: 901 bytes --]



Quoting Vladimir 'φ-coder/phcoder' Serbinenko, who wrote the following on...:

> On 26.10.2011 22:54, Keshav P R wrote:
>> On Thu, Oct 27, 2011 at 02:18, Seth Goldberg <seth.goldberg@oracle.com
>> <mailto:seth.goldberg@oracle.com>> wrote:
>>
>>     Hi,
>>
>>      Personally, I'd love to see boot-directory go away also -- I
>>     think you should be able to specify the exact directory you want
>>     without worrying about /grub being appended.  Same goes for mkconfig.
>>
>>      --S
>>
>>
>> Yes, that would be best and gives direct control to the user. For now
>> GRUB_PREFIX denotes that final dir (atleast in the scripts).
>>
> Ok, I open directory you specifiec without thinking too much and spill
> loads of files in it. Happy sorting.

   That's kinda the way I feel about boot-directory ;).  One cannot protect 
users from themselves for everything ;).

  --S

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-10-26 21:07           ` Seth Goldberg
@ 2011-10-26 21:14             ` Vladimir 'φ-coder/phcoder' Serbinenko
  2011-10-26 21:22               ` Seth Goldberg
  0 siblings, 1 reply; 15+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2011-10-26 21:14 UTC (permalink / raw)
  To: grub-devel

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

On 26.10.2011 23:07, Seth Goldberg wrote:
>
>
> Quoting Vladimir 'φ-coder/phcoder' Serbinenko, who wrote the following
> on...:
>
>> On 26.10.2011 22:54, Keshav P R wrote:
>>> On Thu, Oct 27, 2011 at 02:18, Seth Goldberg <seth.goldberg@oracle.com
>>> <mailto:seth.goldberg@oracle.com>> wrote:
>>>
>>>     Hi,
>>>
>>>      Personally, I'd love to see boot-directory go away also -- I
>>>     think you should be able to specify the exact directory you want
>>>     without worrying about /grub being appended.  Same goes for
>>> mkconfig.
>>>
>>>      --S
>>>
>>>
>>> Yes, that would be best and gives direct control to the user. For now
>>> GRUB_PREFIX denotes that final dir (atleast in the scripts).
>>>
>> Ok, I open directory you specifiec without thinking too much and spill
>> loads of files in it. Happy sorting.
>
>   That's kinda the way I feel about boot-directory ;).  One cannot
> protect users from themselves for everything ;).
>
Then you'll probably agree to rediscuss this issue after all
platform-specific files are moved into their subdirectories. Should take
care of the most of issue nicely.
>  --S
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-10-26 21:14             ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2011-10-26 21:22               ` Seth Goldberg
  2011-10-26 21:42                 ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 1 reply; 15+ messages in thread
From: Seth Goldberg @ 2011-10-26 21:22 UTC (permalink / raw)
  To: The development of GNU GRUB


>>   That's kinda the way I feel about boot-directory ;).  One cannot
>> protect users from themselves for everything ;).
>>
> Then you'll probably agree to rediscuss this issue after all
> platform-specific files are moved into their subdirectories. Should take
> care of the most of issue nicely.

  I think that addresses my personal issue, but maybe not for others that want 
to put it in directory X not X/$platform.  Would you be amenable to an 
additional override flag?  Like --force-prefix=/real/path/to/modules_and_stuff?

  --S


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-10-26 21:22               ` Seth Goldberg
@ 2011-10-26 21:42                 ` Vladimir 'φ-coder/phcoder' Serbinenko
  2011-10-26 22:23                   ` Seth Goldberg
  0 siblings, 1 reply; 15+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2011-10-26 21:42 UTC (permalink / raw)
  To: grub-devel

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

On 26.10.2011 23:22, Seth Goldberg wrote:
>
>>>   That's kinda the way I feel about boot-directory ;).  One cannot
>>> protect users from themselves for everything ;).
>>>
>> Then you'll probably agree to rediscuss this issue after all
>> platform-specific files are moved into their subdirectories. Should take
>> care of the most of issue nicely.
>
>  I think that addresses my personal issue, but maybe not for others
> that want to put it in directory X not X/$platform.  Would you be
> amenable to an additional override flag?  Like
> --force-prefix=/real/path/to/modules_and_stuff?
>
prefix will be "X". Just on runtime it will add platform to it when
loading modules and .lst (but not locale, themes and grub.cfg)
>  --S
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-10-26 21:42                 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2011-10-26 22:23                   ` Seth Goldberg
  2011-11-22  9:21                     ` Keshav P R
  0 siblings, 1 reply; 15+ messages in thread
From: Seth Goldberg @ 2011-10-26 22:23 UTC (permalink / raw)
  To: The development of GNU GRUB

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1306 bytes --]



Quoting Vladimir 'φ-coder/phcoder' Serbinenko, who wrote the following on...:

> On 26.10.2011 23:22, Seth Goldberg wrote:
>>
>>>>   That's kinda the way I feel about boot-directory ;).  One cannot
>>>> protect users from themselves for everything ;).
>>>>
>>> Then you'll probably agree to rediscuss this issue after all
>>> platform-specific files are moved into their subdirectories. Should take
>>> care of the most of issue nicely.
>>
>>  I think that addresses my personal issue, but maybe not for others
>> that want to put it in directory X not X/$platform.  Would you be
>> amenable to an additional override flag?  Like
>> --force-prefix=/real/path/to/modules_and_stuff?
>>
> prefix will be "X". Just on runtime it will add platform to it when
> loading modules and .lst (but not locale, themes and grub.cfg)

   Sorry -- prefix is the wrong term.  It is interesting that you're going 
beyond what I thought, though; I thought you were just going to do what 
grub-mkrescue did by creating the platform subdirs and putting grub.cfg in 
there that does platform-specific stuff then sources ../grub.cfg;  I think 
that was a good approach, since you ended up with the generic entries in the 
../grub.cfg file and platform-specific goodness in the platform dirs.

  --S

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-10-26 22:23                   ` Seth Goldberg
@ 2011-11-22  9:21                     ` Keshav P R
  2011-11-25 13:26                       ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 1 reply; 15+ messages in thread
From: Keshav P R @ 2011-11-22  9:21 UTC (permalink / raw)
  To: The development of GNU GRUB


[-- Attachment #1.1: Type: text/plain, Size: 1239 bytes --]

On Thu, Oct 27, 2011 at 03:53, Seth Goldberg <seth.goldberg@oracle.com>wrote:

>
> Quoting Vladimir 'φ-coder/phcoder' Serbinenko, who wrote the following
> on...:
>
>  prefix will be "X". Just on runtime it will add platform to it when
>> loading modules and .lst (but not locale, themes and grub.cfg)
>>
>
>  Sorry -- prefix is the wrong term.  It is interesting that you're going
> beyond what I thought, though; I thought you were just going to do what
> grub-mkrescue did by creating the platform subdirs and putting grub.cfg in
> there that does platform-specific stuff then sources ../grub.cfg;  I think
> that was a good approach, since you ended up with the generic entries in
> the ../grub.cfg file and platform-specific goodness in the platform dirs.
>


For now can you please check-in
grub-mkconfig-Use_outside_GRUB_PREFIX_if_defined.patch (file attached). I
can't think of any other way more simple than this. For usage like (as root)

  # GRUB_PREFIX="/boot/efi/efi/grub" grub-mkconfig -o
/boot/efi/efi/grub/grub.cfg

This is definitely not the best or the long-term solution but for now this
will suffice (till the actual option to be used is decided). Thanks in
advance.

Regards.

Keshav

[-- Attachment #1.2: Type: text/html, Size: 1762 bytes --]

[-- Attachment #2: grub-mkconfig-Use_outside_GRUB_PREFIX_if_defined.patch --]
[-- Type: text/x-patch, Size: 788 bytes --]

commit e744fe45dc0f349156d92b37349619cfbaec8f2f
Author: Keshav P R <the.ridikulus.rat@gmail.com>
Date:   Tue Nov 22 14:39:54 2011 +0530

    grub-mkconfig: Use outside GRUB_PREFIX if defined

diff --git a/util/grub-mkconfig.in b/util/grub-mkconfig.in
index e317279..a229811 100644
--- a/util/grub-mkconfig.in
+++ b/util/grub-mkconfig.in
@@ -40,7 +40,9 @@ grub_mkdevicemap=${sbindir}/`echo grub-mkdevicemap | sed "${transform}"`
 grub_probe=${sbindir}/`echo grub-probe | sed "${transform}"`
 grub_script_check="${bindir}/`echo grub-script-check | sed "${transform}"`"
 
-GRUB_PREFIX=`echo '/@bootdirname@/@grubdirname@' | sed "s,//*,/,g"`
+if test -z "${GRUB_PREFIX}"; then
+    GRUB_PREFIX=`echo '/@bootdirname@/@grubdirname@' | sed "s,//*,/,g"`
+fi
 
 # Usage: usage
 # Print the usage.

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: Add prefix option to grub-mkconfig
  2011-11-22  9:21                     ` Keshav P R
@ 2011-11-25 13:26                       ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 0 replies; 15+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2011-11-25 13:26 UTC (permalink / raw)
  To: grub-devel

On 22.11.2011 10:21, Keshav P R wrote:
> On Thu, Oct 27, 2011 at 03:53, Seth Goldberg <seth.goldberg@oracle.com 
> <mailto:seth.goldberg@oracle.com>> wrote:
>
>
>     Quoting Vladimir 'φ-coder/phcoder' Serbinenko, who wrote the
>     following on...:
>
>         prefix will be "X". Just on runtime it will add platform to it
>         when
>         loading modules and .lst (but not locale, themes and grub.cfg)
>
>
>      Sorry -- prefix is the wrong term.  It is interesting that you're
>     going beyond what I thought, though; I thought you were just going
>     to do what grub-mkrescue did by creating the platform subdirs and
>     putting grub.cfg in there that does platform-specific stuff then
>     sources ../grub.cfg;  I think that was a good approach, since you
>     ended up with the generic entries in the ../grub.cfg file and
>     platform-specific goodness in the platform dirs.
>
>
> For now can you please check-in 
> grub-mkconfig-Use_outside_GRUB_PREFIX_if_defined.patch (file 
> attached). I can't think of any other way more simple than this. For 
> usage like (as root)
>
>   # GRUB_PREFIX="/boot/efi/efi/grub" grub-mkconfig -o 
> /boot/efi/efi/grub/grub.cfg
>
Without the rest it's an inconsistent kludge.
> This is definitely not the best or the long-term solution but for now 
> this will suffice (till the actual option to be used is decided). 
> Thanks in advance.
>
> Regards.
>
> Keshav
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2011-11-25 13:27 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-22 18:02 Add prefix option to grub-mkconfig KESHAV P.R.
2011-09-16  6:17 ` KESHAV P.R.
2011-09-16 17:18   ` Seth Goldberg
2011-10-13 21:29 ` Jamie Kitson
2011-10-26 20:44   ` Keshav P R
2011-10-26 20:48     ` Seth Goldberg
2011-10-26 20:54       ` Keshav P R
2011-10-26 21:04         ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-10-26 21:07           ` Seth Goldberg
2011-10-26 21:14             ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-10-26 21:22               ` Seth Goldberg
2011-10-26 21:42                 ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-10-26 22:23                   ` Seth Goldberg
2011-11-22  9:21                     ` Keshav P R
2011-11-25 13:26                       ` Vladimir 'φ-coder/phcoder' Serbinenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).