From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ROQDG-0004GV-UC for mharc-grub-devel@gnu.org; Thu, 10 Nov 2011 03:42:22 -0500 Received: from eggs.gnu.org ([140.186.70.92]:50093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROQDB-0004AG-NW for grub-devel@gnu.org; Thu, 10 Nov 2011 03:42:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROQDA-00053k-0m for grub-devel@gnu.org; Thu, 10 Nov 2011 03:42:17 -0500 Received: from mail-ey0-f169.google.com ([209.85.215.169]:48105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROQD9-00053f-L6 for grub-devel@gnu.org; Thu, 10 Nov 2011 03:42:15 -0500 Received: by eye4 with SMTP id 4so2443719eye.0 for ; Thu, 10 Nov 2011 00:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=tgt4V1YipRYy/X8ZE5j2QC5P5naq/hkIg9mJlI7PpfE=; b=wAbtWfP6PjslklDhz9YZ3IEOqT6ADFk+bKOmtZ3WYRSkueYI4BpQD+31bM8g41iYEg DVVSELV0z5tN1vGb4ssd8riuCmR70LV0igxUmWUSXVVkW5npxHEgqZGfbH8+z3WgVAte y2B9oklGJdCiWXGZjXF6OJ4M0hTwkfQjk3nqE= Received: by 10.14.23.133 with SMTP id v5mr470317eev.194.1320914534549; Thu, 10 Nov 2011 00:42:14 -0800 (PST) Received: from debian.x201.phnet (public-docking-hg-8-042.ethz.ch. [195.176.121.42]) by mx.google.com with ESMTPS id t6sm20489826eeb.11.2011.11.10.00.42.12 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 10 Nov 2011 00:42:13 -0800 (PST) Message-ID: <4EBB8E63.6000009@gmail.com> Date: Thu, 10 Nov 2011 09:42:11 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20111010 Iceowl/1.0b2 Icedove/3.1.15 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] Export functions to allow any module to perform primitive operations on serial port devices References: In-Reply-To: X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig8C1A76227FE318B9EE7DE509" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.215.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2011 08:42:19 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8C1A76227FE318B9EE7DE509 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07.11.2011 22:13, Shea Levy wrote: > Hello, > > On Thu, Oct 27, 2011 at 2:31 PM, Shea Levy wr= ote: >> Hello all, >> >> These two commits make it straightforward for any module to interact >> with serial devices. The essential change is making grub_serial_find >> non-static and declaring it in serial.h, but I also added some inline >> convenience functions so you can call grub_serial_port_whatever(port, >> other-args) instead of port -> driver -> whatever(port, other-args). >> >> Cheers, >> Shea Levy >> > I've updated the patch to include a ChangeLog and to fix problems with = tabs. ChangeLog entry wasn't following convention and indentation was all wrong. I've fix it this time but I won't do it next one. > Cheers, > Shea Levy > > > # Bazaar merge directive format 2 (Bazaar 0.90) > # revision_id: slevy@tieronedesign.com-20111107210252-hpgs4r476o72t0vj > # target_branch: http://bzr.savannah.gnu.org/r/grub/trunk/grub/ > # testament_sha1: 4ed3bc7da4813bab2e805390b044ff612e9fc869 > # timestamp: 2011-11-07 16:09:33 -0500 > # base_revision_id: phcoder@gmail.com-20111027010427-w9m1evhnf25d47bp > # > # Begin patch > =3D=3D=3D modified file 'ChangeLog' > --- ChangeLog 2011-10-27 01:04:27 +0000 > +++ ChangeLog 2011-11-07 21:02:52 +0000 > @@ -1,3 +1,12 @@ > +2011-11-07 Shea Levy > + > + Allow all modules to perform serial IO > + > + * grub-core/term-serial.c (grub_serial_find): Remove static qualifier= > + * include/grub/serial.h: Add grub_serial_find() prototype > + Add inlined grub_serial_port_* functions corresponding to each of the= > + functions in struct grub_serial_driver > + > 2011-10-26 Vladimir Serbinenko > > Support NTFS reparse points. > =3D=3D=3D modified file 'grub-core/term/serial.c' > --- grub-core/term/serial.c 2011-10-14 17:16:37 +0000 > +++ grub-core/term/serial.c 2011-10-27 17:14:47 +0000 > @@ -125,7 +125,7 @@ > > > > -static struct grub_serial_port * > +struct grub_serial_port * > grub_serial_find (char *name) > { > struct grub_serial_port *port; > =3D=3D=3D modified file 'include/grub/serial.h' > --- include/grub/serial.h 2011-02-19 12:18:05 +0000 > +++ include/grub/serial.h 2011-11-07 20:55:49 +0000 > @@ -96,6 +96,29 @@ > > void EXPORT_FUNC(grub_serial_unregister) (struct grub_serial_port *por= t); > > + /* Convenience functions to perform primitive operations on a port. = */ > +static inline grub_err_t grub_serial_port_configure > + (struct grub_serial_port *port, struct grub_serial_config *config) > +{ > + return port->driver->configure (port, config); > +} > + > +static inline int grub_serial_port_fetch (struct grub_serial_port *por= t) > +{ > + return port->driver->fetch (port); > +} > + > +static inline void grub_serial_port_put (struct grub_serial_port *port= , > + const int c) > +{ > + port->driver->put (port, c); > +} > + > +static inline void grub_serial_port_fini (struct grub_serial_port *por= t) > +{ > + port->driver->fini (port); > +} > + > /* Set default settings. */ > static inline grub_err_t > grub_serial_config_defaults (struct grub_serial_port *port) > @@ -117,6 +140,7 @@ > > void grub_ns8250_init (void); > char *grub_serial_ns8250_add_port (grub_port_t port); > +struct grub_serial_port *grub_serial_find (char *name); > extern struct grub_serial_driver grub_ns8250_driver; > void EXPORT_FUNC(grub_serial_unregister_driver) (struct > grub_serial_driver *driver); > > # Begin bundle > IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWdwP64gABSXfgGAwUHf= //3ok > ngC////6YAkLvq7Y+jzoADO7N3uMiuEJKolDKmI1GQaGgaeiAAAAGjQAJKATCDQmmkp7Kh6= g0GgB > kADQc0xMBGmBGEYAAAAmEYCSRqE2oj0mmTQaaPUZDIAND1GmmjQIpI0TU9Apt6lHlPKaaHt= RMmJ5 > GoNAACKQmhGmgJkaYmg1MpphPUZANGhpQJKQFEujSiRCGsMav0tGFjHZhEcCAmS1D2ttQBX= MIDfi > zPg1VcK/8Dt71Sr8OeNDfGiBbj2RzhKKhVzovkOUnK4q4WwwBGttkoI0aC1ZZixxjE5yyG+= wRyhS > t0iISIiGCPpehWjlCB3bpEFlJTN9kqE5UiyFK8syu82mwHJ9s/aukz4Za8lO0GqpTxTDSC0= MJhiG > 4o7QmUs0bg3lxQ7KBma6TE1/2czEoXLSzIFhQA8iITy2Ir7LiGYBMgD6bjXdw5lZw8p3JvI= Di1pI > jEsIjvbxt46tyDlBfi80KOvUSzszoJgqMytH2SO7rCEA6FwQnlIIam8PgPe2PEGixe3l7MN= /JC2+ > nGnkplVYQ9mtOXY8jbqbs9hKUpSk5MCLwcxAQwkrnwnyNlAqur3aiJhkCDy90gAvMl0oruJ= Kk5yS > +pTk41yDirJbsxYTW4uzCWr4W2lMUJue+Z6WWezuq5GcH1XchUOA0VmTrtFzQYWFSNrUNtC= 0YAJh > Ss14Dp72aButlEAGCyJKwIGH4QE2C1uZ9RAULYtUlrnLjY7LbrcsluqbfoGXKRto9b0Bd10= XbTaH > A6bgUGA/iZy+3pckQ2GQN3iuHKBjuZPJUyOBymsGKC8SNluLwFKdF1IysgC+6CkgYidxMfl= N3aCR > wSlIXjFgSxCeAOiAN2U4xIkksR0C/FHoUcIG7dBkDAF60GgqkszNOBgSSnndz6DTzu2ga98= O7gyg > lupNLtCssClWjob7V0MexGkzSj0i/k1pYJuWYPahYGZMEwuKwUwQTbTzFmVUfsTVolXmpI3= 6zeMy > 5F0DUlHPbEuPtrIUA3vXAiGSB8p1QbA1iYR462rYtERYRWYwNj3dAoMfy3Yu3nOnV0TfR5A= FcnEy > KTHHabJF5cGugS2scJnCzA0hvYoObfSGVNewDBUwWbMjYE1wPa1EUGBtaRRCiCmGMKuSUAY= l9osp > RGkc8qCfhJo0yOE81WojWcwpmeiTwwLaMG1YxvR4Y5Dm2KwwK2iV6Xlf3B1z1UNkw4UIDcS= rT5c0 > tN5jGXEP0ZmRgWjojdJ8EokmKEsomhAwNSpsYEBspk6E8TH01JGyeJik5xqfiHtfxMpbVky= lsbqG > LGLBN2tWUOlktGQlgyasWLaJcpdVhvTwXSF/m6wlG6URBKIIOsiIiDD1vvDnSphwHrVd2N7= i/KMA > RBEH4vmR/HodDmubT6+k6oT0wvkq4MZIQExcYZYFCCREGXv76okwNdQwO6VReffxMfPgXVg= wPt0M > p6xIg866XQp8AeY+qIe4jZuTa2u0POPfoQMgbIbRtO3GvShnTTvQkFINOUMZI65T13bPTty= Clpv5 > M7+vGKvHwE19Z6hLuJvcYRNKF9el1m6+MM47s3FhpTzy3hEKjluMaXxEEhZq6IeTai2WA2C= CBWOP > jaRLI+JBrQvHe7zAiRNI5dTn7O03DcQcTnlew5yBzAYCQ5SanE6bZZshoJ5+76pzsPA6mtx= m+Q9S > rPLiug37wjU/pedEPO7nLy+8J6jAtCD7tjULi9+tj810OxxyQUZt9+h+AQcY28WPV4t9Qah= aJ1Yw > YDVqbAxI6hn8Zk7xnOf0XOTyqNSSb9I6POVeWKEiTkcpkaWcb3pwpN4ao72Y5j1O85mlYQg= TXOcQ > Gzt3sh0lIfMUKNVXxo8JtqrkOI7iRrCEf9C1VyKVfI8dZG3r3haubtoYkekjjoJbhw48yFi= zyj3S > wHDEmQPe4gVLeDhBoj+w+cPiC8ckeNd7YHR9AcwMmfzhwtN8iDyZkKSkf4Nar1FhvYDuh3k= A3u4f > FcRqDgMMMdIv8JPeFo4H9Dk+vYFg7qHMp1NwbRQgYrdRa6weZSTWYFogdC+4qaKsHTcMgcQ= No3ms > ax+Klw5rysmBswdLY5Ub1toj2JVkHVwtDG1KRvDbqXxQ3g9am2+ByjCHYDgjRkDNEoD5WKs= zeMGt > +djaXcFhzuQHUGhAIPQJB6jNcE62q7mKvbgVarZYWkiTcqw9UL43heXtrnSECpAwIHoEJJo= EGJsJ > D8AZgSKgCIEkSQoDt2pQdA5+XMb9JG0z2gJMxo+guVeDNK1jCK7CHIpUYifJZF4LRDTUkZz= Pcsm/ > sYCBPtNer41iCJRIyFrD1jcO7T3FeY/TidCCCiUHXymZGCgb7KLxWtZmV2EIdY98hnoU0tR= kKilW > JAqXmL7GS2IJjoPaORowuU7ZqtapxCq0hFhjAALEJIblr0ITGet4zch0HDhDBBDiiamkRBE= Egqq8 > kZBkTVDEEWlzBakEiJBBIiXvC5M8OwMCxT8pEzkFN24geu/ozgdE9lAOwICbHwHVczSgR4A= WoaCy > bsaUOUDndayLXZA+CrjaDoayDXamZTOhcRJDFISbnImbQ8CwANEIZnAGqAOTOaDadVUIQwp= gYqTH > FAxHOSUCzilQYQs8ZqS4Idocr6lgZKvQFAcp5sSXPOB/xdyRThQkNwP64gA=3D > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig8C1A76227FE318B9EE7DE509 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk67jmMACgkQNak7dOguQgmb7QD/QmCh2gbJv5YHejCxbWGi6HgW gnMzDLjGH0NLxtrAhM4A+wS3cIakUL8CU0e1Ui3lM1KMm+W2rdQ72BYaLTUen+HD =4xO4 -----END PGP SIGNATURE----- --------------enig8C1A76227FE318B9EE7DE509--