Re: encrypted partitions aren't recognized in a good way

Re: encrypted partitions aren't recognized in a good way

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

Moving to grub-devel.
On 20.07.2011 14:27, devkral wrote:
> Hello,
> the scripts to generate a grub.cfg file doesn't find lvm under encrypted
> partitions (arch).
> Debian has fixed this problem elsewise but it would be nice to have a clean
> way detecting such partitions.
> I attach a patch to do so with an alternative /etc/grub.d/10_linux file (cryptgrub2.patch).
>
> Cryptswapgrub2.patch includes also a fix
> for hibernation support with encrypted swap-partitions (it includes
> every swap device in fstab invoked by the "resume=" command in the kernel argument list,
> so I'm not sure if this hasn't annoying consequences).
>
These options are distro-specific but it's ok to provide the debian ones
and let distros handle the differences. On the other hand this uses
third-party tools which shouldn't be necessary since grub in bzr trunk
already has LUKS support. Could you use our own grub-probe as base? Also
we should supply the LUKS UUID and not underlying device since it's
subject to change.
> Regards,
> Alex 
>
>
>
> _______________________________________________
> Bug-grub mailing list
> Bug-grub@gnu.org
> https://lists.gnu.org/mailman/listinfo/bug-grub


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

Re: encrypted partitions aren't recognized in a good way

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

Please keep the list CC'ed.
On 21.07.2011 21:39, devkral wrote:
> sorry, I don't understand the uuid-LUKS logic of grub-probe and dmsetup
> doesn't support this check.
dmsetup info /dev/mapper/mycrypt gives:
...
UUID: CRYPT-LUKS1-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-mycrypt_unformatted
And with grub-probe -t cryptodisk_uuid /mnt/crypt
you have:
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Where xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx is the unique UUID which is also
used in /dev/disk/by-uuid/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx, just
formatted differently.
The patch as is unnecessarily uses a heavily different codepath than
non-crypt ones. From maintainance point of view this is unacceptable.

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

Re: encrypted partitions aren't recognized in a good way

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

Keep the list CC'ed. It's not difficult
On 24.07.2011 01:26, devkral wrote:
> Am Donnerstag, den 21.07.2011, 21:51 +0200 schrieb Vladimir
> 'φ-coder/phcoder' Serbinenko:
>> Please keep the list CC'ed.
>> On 21.07.2011 21:39, devkral wrote:
>>> sorry, I don't understand the uuid-LUKS logic of grub-probe and dmsetup
>>> doesn't support this check.
>> dmsetup info /dev/mapper/mycrypt gives:
>> ...
>> UUID: CRYPT-LUKS1-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-mycrypt_unformatted
>> And with grub-probe -t cryptodisk_uuid /mnt/crypt
>> you have:
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
>> Where xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx is the unique UUID which is also
>> used in /dev/disk/by-uuid/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx, just
>> formatted differently.
>> The patch as is unnecessarily uses a heavily different codepath than
>> non-crypt ones. From maintainance point of view this is unacceptable.
>>
> thx, here the new patch. Sorry for the delay.


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

Re: encrypted partitions aren't recognized in a good way

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]

On 24.07.2011 13:48, devkral wrote:
> Am Donnerstag, den 21.07.2011, 21:51 +0200 schrieb Vladimir
> 'φ-coder/phcoder' Serbinenko:
>> Please keep the list CC'ed.
Keep the list CC'ed. Idon't accept patches sent privately
>> On 21.07.2011 21:39, devkral wrote:
>>> sorry, I don't understand the uuid-LUKS logic of grub-probe and dmsetup
>>> doesn't support this check.
>> dmsetup info /dev/mapper/mycrypt gives:
>> ...
>> UUID: CRYPT-LUKS1-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-mycrypt_unformatted
>> And with grub-probe -t cryptodisk_uuid /mnt/crypt
>> you have:
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
>> Where xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx is the unique UUID which is also
>> used in /dev/disk/by-uuid/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx, just
>> formatted differently.
>> The patch as is unnecessarily uses a heavily different codepath than
>> non-crypt ones. From maintainance point of view this is unacceptable.
>>
> I have had a logical mistake in my patch (the ':' doesn't vanish like
> dmsetup … -c -o vg_name). Here the corrected version of my patch.


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

Re: encrypted partitions aren't recognized in a good way

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

On 20.07.2011 14:27, devkral wrote:
> Hello,
> the scripts to generate a grub.cfg file doesn't find lvm under encrypted
> partitions (arch).
> Debian has fixed this problem elsewise but it would be nice to have a clean
> way detecting such partitions.
> I attach a patch to do so with an alternative /etc/grub.d/10_linux file (cryptgrub2.patch).
>
Could you update it to use grub-probe as it now has LUKS support?
> Cryptswapgrub2.patch includes also a fix
> for hibernation support with encrypted swap-partitions (it includes
> every swap device in fstab invoked by the "resume=" command in the kernel argument list,
> so I'm not sure if this hasn't annoying consequences).
>
> Regards,
> Alex 
>
>
>
> _______________________________________________
> Bug-grub mailing list
> Bug-grub@gnu.org
> https://lists.gnu.org/mailman/listinfo/bug-grub


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]