From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ROslW-0004fX-Rt for mharc-grub-devel@gnu.org; Fri, 11 Nov 2011 10:11:38 -0500 Received: from eggs.gnu.org ([140.186.70.92]:46676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROslU-0004aS-0F for grub-devel@gnu.org; Fri, 11 Nov 2011 10:11:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROslS-0008Ov-P2 for grub-devel@gnu.org; Fri, 11 Nov 2011 10:11:35 -0500 Received: from mail-bw0-f41.google.com ([209.85.214.41]:58916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROslS-0008Ok-K7 for grub-devel@gnu.org; Fri, 11 Nov 2011 10:11:34 -0500 Received: by bke17 with SMTP id 17so2651766bke.0 for ; Fri, 11 Nov 2011 07:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=FWgfQuEuHwn6Xt0S3ZNqqU3IE88H2Z90YcPK26ymHBE=; b=VdLNGq35qWYm/ltbYHcz6n7yDKjVHlBruca0SwZdb5vigr3Y37MfUjYeQ0cFuU9g30 sttQcApymQUBe3MyPjtU2Q/fv1eZ67qgGRPkL1yZr2GEj5Qp+bNW3RVj0L5ykm0A7dau kvrJMb0nToloTZYkjUpvojj7AKIN6ZGOchO8U= Received: by 10.205.118.18 with SMTP id fo18mr5625227bkc.33.1321024293660; Fri, 11 Nov 2011 07:11:33 -0800 (PST) Received: from debian.x201.phnet (43-232.197-178.cust.bluewin.ch. [178.197.232.43]) by mx.google.com with ESMTPS id e8sm11302992bkd.7.2011.11.11.07.11.30 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 Nov 2011 07:11:32 -0800 (PST) Message-ID: <4EBD3B15.1040300@gmail.com> Date: Fri, 11 Nov 2011 16:11:17 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20111010 Iceowl/1.0b2 Icedove/3.1.15 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] Enable install of grub2 in PReP partition References: <4EBD2AE0.7020200@linux.vnet.ibm.com> In-Reply-To: <4EBD2AE0.7020200@linux.vnet.ibm.com> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig9CD20C2BE99DF54A9C3FA3C6" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.214.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2011 15:11:37 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9CD20C2BE99DF54A9C3FA3C6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11.11.2011 15:02, Paulo de Rezende Pinatti wrote: > + if (dev->disk->partition =3D=3D NULL) > + { > + grub_util_info ("no partition map found for %s", dev->disk->= name); > + } > + > + if (strcmp(dev->disk->partition->partmap->name, "msdos") =3D=3D = 0) This is wrong, you check for the pointer being non-NULL, issue a warning and then happily dereference it regardless. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig9CD20C2BE99DF54A9C3FA3C6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk69OxwACgkQNak7dOguQglw6gEAuBe3VpvKhQNkEEtWm2wuO8kH f19bksbxXUy3VLkFskEA/iYThofLWOddWw7zPROmK25KQKqncQjlMprwobeQn7VO =XA12 -----END PGP SIGNATURE----- --------------enig9CD20C2BE99DF54A9C3FA3C6--