From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RTvaR-0001eb-Rj for mharc-grub-devel@gnu.org; Fri, 25 Nov 2011 08:13:03 -0500 Received: from eggs.gnu.org ([140.186.70.92]:43713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTvaM-0001eB-AG for grub-devel@gnu.org; Fri, 25 Nov 2011 08:13:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RTvaL-0003JN-8F for grub-devel@gnu.org; Fri, 25 Nov 2011 08:12:58 -0500 Received: from mail-ww0-f49.google.com ([74.125.82.49]:39432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTvaL-0003JF-0A for grub-devel@gnu.org; Fri, 25 Nov 2011 08:12:57 -0500 Received: by wwf5 with SMTP id 5so2249631wwf.30 for ; Fri, 25 Nov 2011 05:12:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=D0Qou2dJqUqthS7UvymFV98oHosjAOOFuO7weTwtdwY=; b=ZrfAOuOulJ4BQwCBqm3ObTeBwngz5xiqp1fdrXlG0qK4AG5haHH7bMjCbbxm8i5dj+ GRvydxfhECVa3J5gtiIU6HSdLhbdAPeGgau4GCknhVzt13z9Oo3Fmo43VDKquzP3ZWnQ MtQvFBjZt0sxtcqT8KCgGe7QVPTlSfbtNrtI8= Received: by 10.180.4.67 with SMTP id i3mr34584953wii.1.1322226776401; Fri, 25 Nov 2011 05:12:56 -0800 (PST) Received: from debian.bg45.phcoder (public-docking-hg-2-022.ethz.ch. [129.132.247.22]) by mx.google.com with ESMTPS id v10sm10669137wiy.23.2011.11.25.05.12.53 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 25 Nov 2011 05:12:54 -0800 (PST) Message-ID: <4ECF9452.9090805@gmail.com> Date: Fri, 25 Nov 2011 14:12:50 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: Tar fs module appears to be broken References: <4ec7061c.c5b3ec0a.292a.ffffedd8@mx.google.com> In-Reply-To: <4ec7061c.c5b3ec0a.292a.ffffedd8@mx.google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.49 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2011 13:13:02 -0000 Fixed On 19.11.2011 02:27, Glenn Washburn wrote: > Hi all, > > I'm in the middle of debugging an issue with the tar fs module, but > thought sharing it with the list might make it go faster. With the > attached tar file, and any tar file it seems, I am only able to see > files which are children of root. So in this case, I can see /boot, > but not /boot/grub or /boot/grub/test.cfg. This tar file was created > with regular gnu tar. > > I've added some debug print statements, and I can see that > grub_cpio_find_file is returning all paths from the archive. So the > problem would seem to be in grub_cpio_dir. I'm currently stuck trying > to figure out how the big if in the while loop is supposed to work. > For one, all code referencing the local variable "n" appears to be > extraneous (if so, let's remove it). The local variable "p" seems to be > used to get the next path component and also used to tell if the path > is a directory. It appears that "(!prev) || (grub_strcmp (prev, > name) != 0)" is always false, except the first time through the loop > because prev == "boot" and name == "boot". I'm guessing there's > something wrong with this condition, but I haven't completely figured > out what its supposed to be doing at a high level. > > This piece of code is a little convoluted so it might be good to put > some comments in to clarify what's going on. What's strange is that I > thought I remembered this very case working a couple weeks ago. Can > someone verify that they see this issue with this tar file before > digging into the code? > > I won't be able to respond till after the weekend, but I thought I'd > send this out if anyone else wanted to take a stab at it. > > Glenn > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'φ-coder/phcoder' Serbinenko