From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RWMFG-0001W5-Qj for mharc-grub-devel@gnu.org; Fri, 02 Dec 2011 01:05:14 -0500 Received: from eggs.gnu.org ([140.186.70.92]:33638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWMFE-0001Vz-2O for grub-devel@gnu.org; Fri, 02 Dec 2011 01:05:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RWMFC-0003eA-Hx for grub-devel@gnu.org; Fri, 02 Dec 2011 01:05:11 -0500 Received: from mail-ww0-f49.google.com ([74.125.82.49]:40393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWMFC-0003e5-9I for grub-devel@gnu.org; Fri, 02 Dec 2011 01:05:10 -0500 Received: by wgbdt11 with SMTP id dt11so326671wgb.30 for ; Thu, 01 Dec 2011 22:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=U2VWiNNaLMicAsG6HWv7sWpH+W8jd4Kts053xDo8C7Q=; b=qUP9riTbmgyiAEylDP3Hf+lcnXSRk3/olldg9wsXamoRfiGi3vfc7SQWUJ2ECKF+iP lFw2hXV4trCKUJmv18bGuwun3CafklsKFxjpDSWHhfstBUr9/6f8w6nQr4INjj2Erz+G f9JTAxyJF4yX/LXJIs989j3Ik57+eGHobuMsk= Received: by 10.180.107.231 with SMTP id hf7mr4366150wib.68.1322805909483; Thu, 01 Dec 2011 22:05:09 -0800 (PST) Received: from debian.x201.phnet (77-232.197-178.cust.bluewin.ch. [178.197.232.77]) by mx.google.com with ESMTPS id b5sm8727919wbh.4.2011.12.01.22.05.07 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 01 Dec 2011 22:05:08 -0800 (PST) Message-ID: <4ED86A92.3000506@gmail.com> Date: Fri, 02 Dec 2011 07:05:06 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: New command to check NT's hibernation state References: <4ED85F41.5070605@gmail.com> In-Reply-To: <4ED85F41.5070605@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.49 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2011 06:05:13 -0000 Hello. On 02.12.2011 06:16, Peter Lustig wrote: >> Thanks for this. However the coding style isn't according to our >> standards. Could you adjust to the standard? I recommend looking at >> other code and reading GNU Coding Standard. E.g. we don't use {0} >> initialiser, return value of commands, C++ comments or M$-$tyle >> variables. > > Sorry about that. I've reviewed the standard and perused the source > tree, as you suggested, to determine the best style. Attached is my > updated file. > Much better. There are still few problems like the arbitrary limit (we avoid any arbitrary limits, you have one easy to avoid on filename length). Also we don't use such ABORT macros as they offer no readability advantage. Review in more details when time permits. > Glad to be of help, > Peter Lustig > > P.S. Do you know if there are any plans in the future to implement > write operations for filesystems? (I noticed raw disk writing is > currently supported.) If not, is the reason due to the technical > challenges (e.g. NTFS only had read-only access in GNU/Linux for quite > a while) or just a general lack of interest? Neither. Reliability concerns. Writing to filesystem is potentially dangerous and needs to be throughly tested. Since writing is rare for bootloader we won't receive enough testing of these code pathes so every write will remain a risk. We can't have such risks. > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'φ-coder/phcoder' Serbinenko