From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RbscX-0002tl-9z for mharc-grub-devel@gnu.org; Sat, 17 Dec 2011 06:40:05 -0500 Received: from eggs.gnu.org ([140.186.70.92]:37350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbscT-0002oQ-Hz for grub-devel@gnu.org; Sat, 17 Dec 2011 06:40:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbscR-0005hq-Rc for grub-devel@gnu.org; Sat, 17 Dec 2011 06:40:01 -0500 Received: from mail-wi0-f169.google.com ([209.85.212.169]:50832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbscR-0005hM-FR for grub-devel@gnu.org; Sat, 17 Dec 2011 06:39:59 -0500 Received: by wibhq12 with SMTP id hq12so485076wib.0 for ; Sat, 17 Dec 2011 03:39:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=iul22UkbkB3Jvr72nxeFAhkaMtIDZI+GlTbeDEEtPcE=; b=SEgrQriaBiNSBKFcnrR5OjHvfziOe6Tszmu5baY09Xcc7jpWd8T/wi02CLPumQpx1U hkKPz2dZX21Nb/3Ne6DBl34tWbQQXd5zFLh0Ng7yy68iKHBkKGIWWxHVjoSUMEwBtK1/ dgOihK4fVgUJkjNoSWkr65uuLvAAFOOnHHDmY= Received: by 10.180.74.211 with SMTP id w19mr17814246wiv.7.1324121998391; Sat, 17 Dec 2011 03:39:58 -0800 (PST) Received: from debian.x201.phnet (210-148.203-62.cust.bluewin.ch. [62.203.148.210]) by mx.google.com with ESMTPS id er5sm18031087wbb.11.2011.12.17.03.39.49 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 17 Dec 2011 03:39:56 -0800 (PST) Message-ID: <4EEC7F7D.2050900@gmail.com> Date: Sat, 17 Dec 2011 12:39:41 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: New command to check NT's hibernation state References: <4EEC2B8E.9060003@gmail.com> In-Reply-To: <4EEC2B8E.9060003@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.212.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2011 11:40:02 -0000 >>> /* Try to open 'hiberfil.sys' */ >>> hibr_file = grub_file_open (hibr_file_path); >>> if (!hibr_file) >>> { >>> if (grub_errno == GRUB_ERR_FILE_NOT_FOUND) >>> grub_error (GRUB_ERR_FILE_NOT_FOUND, N_("'hiberfil.sys' not >>> found")); >> This overriding is unnecessary. FS code already provides this message > This was intentional: the default message ('file not found') is not > particularly helpful in this case since the > command's description nowhere mentions what file it's looking for (let > alone that any file is needed for it to > function). I've updated this section to pop the first error off the > stack to eliminate the duplication (and added > a descriptive comment). This means that your copy of GRUB is old. Newer ones do have the descriptive message. And even if it wasn't the case it's something to be fixed in FS code, not by replacing error message here. -- Regards Vladimir 'φ-coder/phcoder' Serbinenko