From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RdhTo-0006Ow-5b
	for mharc-grub-devel@gnu.org; Thu, 22 Dec 2011 07:10:36 -0500
Received: from eggs.gnu.org ([140.186.70.92]:55376)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1RdhTl-0006On-VA
	for grub-devel@gnu.org; Thu, 22 Dec 2011 07:10:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1RdhTh-000456-Rd
	for grub-devel@gnu.org; Thu, 22 Dec 2011 07:10:33 -0500
Received: from mail-we0-f169.google.com ([74.125.82.169]:65401)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1RdhTh-00044l-M2
	for grub-devel@gnu.org; Thu, 22 Dec 2011 07:10:29 -0500
Received: by werf1 with SMTP id f1so4326532wer.0
	for <grub-devel@gnu.org>; Thu, 22 Dec 2011 04:10:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=D4c2idkrQTUq0r34WItH7q9OK7hQQ9FeLfYu6ONgETE=;
	b=igb8wnPSHUOYPayRn2zm7t8h7EXJpiVYoXFko6jtUSrJDNm9UwIBlbunjjXtQz1OIS
	Jbjf7cjgn5Mv8LfjzebhnwcL/haVnBWFYlF+cF8TCuQYAe9mGqwvIrKbMiMHEV8ZUHgs
	gPYWemWN4js9Mtt914MHTBKcJfQwNHXCM2iwc=
Received: by 10.216.139.156 with SMTP id c28mr11235348wej.34.1324555829004;
	Thu, 22 Dec 2011 04:10:29 -0800 (PST)
Received: from debian.x201.phnet (cx-public-docking-1-046.ethz.ch.
	[129.132.149.46])
	by mx.google.com with ESMTPS id fy5sm21945159wib.7.2011.12.22.04.10.25
	(version=TLSv1/SSLv3 cipher=OTHER);
	Thu, 22 Dec 2011 04:10:26 -0800 (PST)
Message-ID: <4EF31E31.9020007@gmail.com>
Date: Thu, 22 Dec 2011 13:10:25 +0100
From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?=
	<phcoder@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16
MIME-Version: 1.0
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: New command to check NT's hibernation state
References: <mailman.171.1324141254.27913.grub-devel@gnu.org>
	<4EED5B22.1090904@gmail.com>
In-Reply-To: <4EED5B22.1090904@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 74.125.82.169
Cc: Peter Lustig <peter.lustig.7db@gmail.com>
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Dec 2011 12:10:35 -0000

On 18.12.2011 04:16, Peter Lustig wrote:
>    /* Return SUCCESS if magic indicates file is active; else return FAILURE */
>    if (!grub_strncasecmp ("hibr", hibr_file_magic, magic_size))
What's the reason to use strncasecmp? Does the case changes? Usually 
memcmp is the right way to check the signature. This also avoids the 
need of memset and trailing zero byte.

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko