From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RtFom-0002cV-9r for mharc-grub-devel@gnu.org; Fri, 03 Feb 2012 04:52:32 -0500 Received: from eggs.gnu.org ([140.186.70.92]:34510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtFod-0002Yf-Vi for grub-devel@gnu.org; Fri, 03 Feb 2012 04:52:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtFoc-00075n-NY for grub-devel@gnu.org; Fri, 03 Feb 2012 04:52:23 -0500 Received: from mail-we0-f169.google.com ([74.125.82.169]:46921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtFoc-00075d-Iq for grub-devel@gnu.org; Fri, 03 Feb 2012 04:52:22 -0500 Received: by wera13 with SMTP id a13so3292934wer.0 for ; Fri, 03 Feb 2012 01:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=e10r8SY+bBeyQ1PjtFAjtGYUWNKfiNsUNq/TgXbcZ5Q=; b=C4iRXp4/aCjJt+19Tzz8ural+x5kQG/QqyBd6e0O62tzWx1jD8M4TI7Oc4Qj/oJ1GW Zv9TqaNDJS6yO+qr2WrVZo3n6xo+Gm5YJVeTt+BMk4CZb0BSWRg3QtiVMsytOfmEAJxP B9Q+qdJdZ1LWpB0H62pn4tLyKeBKhgtbWElTA= Received: by 10.216.132.219 with SMTP id o69mr6031213wei.55.1328262741171; Fri, 03 Feb 2012 01:52:21 -0800 (PST) Received: from debian.x201.phnet (180-34.203-62.cust.bluewin.ch. [62.203.34.180]) by mx.google.com with ESMTPS id cb8sm5387230wib.0.2012.02.03.01.52.18 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 03 Feb 2012 01:52:19 -0800 (PST) Message-ID: <4F2BAE50.5060809@gmail.com> Date: Fri, 03 Feb 2012 10:52:16 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120104 Icedove/8.0 MIME-Version: 1.0 To: Richard Laager Subject: Re: [Patch] Robustly search for ZFS labels & uberblocks References: <4E838F85.6060001@gmail.com> <1326973014.6387.224.camel@watermelon.coderich.net> <4F1C1ABD.1010303@gmail.com> <1327719035.9477.68.camel@watermelon.coderich.net> <4F23EF3C.9050407@gmail.com> <1327775600.9477.174.camel@watermelon.coderich.net> <4F25CB6C.7090204@gmail.com> <1327999542.3471.20.camel@watermelon.coderich.net> In-Reply-To: <1327999542.3471.20.camel@watermelon.coderich.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.169 Cc: grub-devel@gnu.org, Zachary Bedell X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2012 09:52:29 -0000 On 31.01.2012 09:45, Richard Laager wrote: > Attached is a stack of trivial patches that apply*on top of* your > zfs.diff from 2012-01-29. They each deal with one logical change and > should be very easy to review. > > After your original patch and this stack have been dealt with, I'll > submit an updated patch for native ZFS on Linux support, which is much > shorter than before. > > -- > Richard > > zfs-on-linux-rlaager0.patch > > > Eliminate stray trailing spaces. We don't do it manually, just from time to time run it automatically on whole codebase. > > zfs-on-linux-rlaager1.patch > > > Change device to devices in find_root_devices_from_libzfs > > > committed > zfs-on-linux-rlaager2.patch > > > Change strlen to sizeof It doesn't matter since GCC changes strlen of const string to just a const. But applied for conformity with the rest of codebase > > zfs-on-linux-rlaager3.patch > > > Avoid crashing when canonicalize_file_name() fails > > I could reproduce this with: grub-probe /dev/sda1 > > > Committed > zfs-on-linux-rlaager4.patch > > > Drop an unused variable. > > > committed. > zfs-on-linux-rlaager5.patch > > > Add braces around and indent the `zpool status` parsing loop Not needed. And we don't put a braces which are not needed. > > zfs-on-linux-rlaager6.patch > > > Handle pool names with trailing spaces What about the ones with spaces in the middle? It feels like the logic is broken elsewhere and using strncmp is just a workaround which works only for one particular case > zfs-on-linux-rlaager7.patch > > > Handle all raidz types in `zpool status` output > > Committed. -- Regards Vladimir 'φ-coder/phcoder' Serbinenko