From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1U0Xsf-0005t0-9K for mharc-grub-devel@gnu.org; Wed, 30 Jan 2013 08:39:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0Xsb-0005sn-3i for grub-devel@gnu.org; Wed, 30 Jan 2013 08:39:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U0XsY-0004St-IZ for grub-devel@gnu.org; Wed, 30 Jan 2013 08:39:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0XsY-0004Sk-9I for grub-devel@gnu.org; Wed, 30 Jan 2013 08:39:06 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0UDd53W012825 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 30 Jan 2013 08:39:05 -0500 Received: from prarit.bos.redhat.com (prarit.bos.redhat.com [10.16.184.34]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0UDd52G011817 for ; Wed, 30 Jan 2013 08:39:05 -0500 Message-ID: <51092278.9000907@redhat.com> Date: Wed, 30 Jan 2013 08:39:04 -0500 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110419 Red Hat/3.1.10-1.el6_0 Thunderbird/3.1.10 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH]: Add GRUB_DISABLE_SUBMENU option References: <1359487413-14528-1-git-send-email-prarit@redhat.com> <20130130000931.280e8823@opensuse.site> <51085C2C.8030206@redhat.com> <20130130090021.5e4e7e06@opensuse.site> In-Reply-To: <20130130090021.5e4e7e06@opensuse.site> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2013 13:39:11 -0000 >> >> /usr/sbin/grub2-reboot 'Advanced options for openSUSE 12.2>openSUSE 12.2, with >> Linux 3.4.6-2.10-desktop (recovery mode)' >> > > That's what good command line completion is for. Really :) Heh :) Fair enough :) > > How is user going to know which number to type? Open grub.cfg and count? This is what I used to do in grub1 ... I wrote a nice little script that dumped the contents of grub config and enumerated the entries so that I could select which one I wanted. FWIW, I could do *exactly* the same thing with grub2, but I'm wondering if there is a "better" way so that the kernel debugging users of grub2 could all benefit. > Actually I have patch to disable submenu somewhere around as well. So I > can well understand your feelings, I just think this is unrelated to > grub-reboot. You're right, and I'm not saying it is :) I like to provide a decent use-case scenario with a patch so people who read it later understand _why_ I've made a change. > >> Alternatively, would you object to me to adding some additional functionality to >> grub2-reboot that would grep grub.cfg and display a menu of entries so that >> 'grub2-reboot #number' would work with submenus? >> > > I think something like "grub-reboot --select" would be interesting, > yes. But it is not for me to decide :) I've talked with a few other kernel engineers, and they like the idea of just adding GRUB_DISABLE_SUBMENU="true" to /etc/default/grub ... IMO it still seems like the easiest approach. Beyond the grub-reboot stuff, do you have any objections to the patch going in? Thanks for your input (and the info!) Andrey. That was really helpful :) P.