From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UASX1-0004J4-JD for mharc-grub-devel@gnu.org; Tue, 26 Feb 2013 16:57:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UASWz-0004I7-Hg for grub-devel@gnu.org; Tue, 26 Feb 2013 16:57:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UASWy-0008JO-FN for grub-devel@gnu.org; Tue, 26 Feb 2013 16:57:49 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:52265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UASWy-0008Is-8f for grub-devel@gnu.org; Tue, 26 Feb 2013 16:57:48 -0500 Received: by mail-wi0-f172.google.com with SMTP id ez12so5483639wid.5 for ; Tue, 26 Feb 2013 13:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=+UfsSVpJAleyrXmm056QPJYhni0BAF+N5QWwOjkPLT0=; b=T4mkR/ZXa384YnNU7N6COP73Fh01p6FexQQKI22UbVQiAb5LKZ7ipP0Mfmslj+oO3P Y3wfKCOp5rdzR+eJIVDSHwdr1grfaOPQu2+10War6eU5cDbfzC0CTE1LtjaGCsMbHRsi jsHCNptVnkLP8t+mwvAPY7ONVm30sn5m6/z6ky4L4Id8sJI0/qTwEsRCQGcA5jn3XGgw 5HkjRCw30xRnnpt/z/kus7ayEo/qHOG6CxICUSr1Efre13xXeCCmcqRi1uNajUVxeZvv E206mvHaxWWf8HO7F4pbJ+6zGsb2yNTc9ReZYVfgvVeEvnrSCGI2yMQH+35+ZA7P8Krn kKhA== X-Received: by 10.194.171.74 with SMTP id as10mr8843733wjc.0.1361915867040; Tue, 26 Feb 2013 13:57:47 -0800 (PST) Received: from debian.x201.phnet ([217.193.148.98]) by mx.google.com with ESMTPS id ex15sm23779526wid.5.2013.02.26.13.57.45 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 26 Feb 2013 13:57:46 -0800 (PST) Message-ID: <512D2FD4.8040300@gmail.com> Date: Tue, 26 Feb 2013 22:57:40 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Remove nested functions from disk and file read hooks References: <20130121121430.GB4066@riva.dynamic.greenend.org.uk> In-Reply-To: <20130121121430.GB4066@riva.dynamic.greenend.org.uk> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig993596A18D3379FDA0771482" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.212.172 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2013 21:57:50 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig993596A18D3379FDA0771482 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 21.01.2013 13:14, Colin Watson wrote: > Part seven. This particular patch in the set loses some of the > compressed-kernel size we'd gained from earlier patches, but it's still= > a good bit smaller than when I started on this work so I'm not worried.= > Note that, as a general pattern, I have intentionally not zeroed out > read_hook_data after calling code using a read hook; this is because (a= ) > the code that calls read hooks only checks whether read_hook is NULL, > (b) every function that sets read_hook to something non-NULL naturally > also sets read_hook_data if it cares about its value, and (c) avoiding > the extra code to zero read_hook_data makes a few bytes of difference t= o > the size of compressed core images. There are some possible improvements that we've discussed on IRC. Apparently you didn't have time to implement them. They can come in separately later if needed. Go ahead. --------------enig993596A18D3379FDA0771482 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlEtL9QACgkQNak7dOguQgmRRgD9F3r7wRrqcIaoS+Zp9sYG6Ads ysCB1OARFTYUWY1i2HUA/2XqcfC49Uzxb9deiYow8tuUF1KFsY1+q3HuYyfsu9qi =qDJX -----END PGP SIGNATURE----- --------------enig993596A18D3379FDA0771482--