From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] gfxterm: check elements' properties and hadle errors.
Date: Thu, 07 Mar 2013 08:31:00 +0100 [thread overview]
Message-ID: <51384234.80102@gmail.com> (raw)
In-Reply-To: <3230726.ejrxcKfAuV@icedphoenix>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On 04.03.2013 12:27, Vladimir Testov wrote:
> + else
> + {
> + return GRUB_ERR_IO;
> + }
This is not a correct error handling. You should never return an error
without calling grub_error. Also in all these contexts you handle the
cases of unknown property name. I don't feel like refusing to load a
theme because of unknown property is a good idea. This would i.a.
exclude older GRUB versions for newer themes even if property in
question is minor in meaning. Compare this to a browser refusing to show
a page because of unknown tag attribute. Also GRUB_ERR_IO hardly
describes a condition of unknown property.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2013-03-07 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 11:27 [PATCH] gfxterm: check elements' properties and hadle errors Vladimir Testov
2013-03-06 18:05 ` Andrey Borzenkov
2013-03-07 7:31 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-07 4:22 Vladimir Testov
2013-03-07 6:03 ` Andrey Borzenkov
2013-03-07 6:29 Vladimir Testov
2013-03-07 7:46 Vladimir Testov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51384234.80102@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).