From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UDVIJ-0004uW-Ms for mharc-grub-devel@gnu.org; Thu, 07 Mar 2013 02:31:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDVIE-0004tI-Oz for grub-devel@gnu.org; Thu, 07 Mar 2013 02:31:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDVID-000490-LB for grub-devel@gnu.org; Thu, 07 Mar 2013 02:31:10 -0500 Received: from mail-wg0-f52.google.com ([74.125.82.52]:40422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDVID-00048r-G3 for grub-devel@gnu.org; Thu, 07 Mar 2013 02:31:09 -0500 Received: by mail-wg0-f52.google.com with SMTP id 12so140838wgh.7 for ; Wed, 06 Mar 2013 23:31:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=P9sOuTrWe6ifVLRMe4dS0ns5MmeBVhDZpZ1x3uYK9As=; b=OD+VNxIhKCJPizZIaPGqNqySeqkdq2sqhaLrJaHZOob2U1p456PUk8hKkZzjd9HC6E LCmjt/7MyJa2QPECeR2fcNiTxibaY8EjPTbBQMlzzVLOiCha5EPtTEuFncNAjltl3KsG 0xoxurEXDHbkq0MDNKplmMhf5YRcnxrz7h0KrSyzsZiAvZgwnVfOUHbZKf0/v1LAO/ME Bs66bOrsYot6dYR8fO0GMnGZBaczeren+XkzeaNJBQmhqSj/mVhTtI1gb+d8GI9eFGYJ ow7xrY330fFtDXuhjwyxF35aIeYmHiHGGK247dqECTbFtyOOPmJ6bpw+9bWgEMMDgTIp SMyA== X-Received: by 10.194.5.137 with SMTP id s9mr52060963wjs.5.1362641468654; Wed, 06 Mar 2013 23:31:08 -0800 (PST) Received: from debian.x201.phnet ([217.193.148.98]) by mx.google.com with ESMTPS id ex15sm31345054wid.5.2013.03.06.23.31.07 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 06 Mar 2013 23:31:07 -0800 (PST) Message-ID: <51384234.80102@gmail.com> Date: Thu, 07 Mar 2013 08:31:00 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] gfxterm: check elements' properties and hadle errors. References: <3230726.ejrxcKfAuV@icedphoenix> In-Reply-To: <3230726.ejrxcKfAuV@icedphoenix> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigBFB73D73372996C299F70312" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.82.52 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2013 07:31:13 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBFB73D73372996C299F70312 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04.03.2013 12:27, Vladimir Testov wrote: > + else > + { > + return GRUB_ERR_IO; > + } This is not a correct error handling. You should never return an error without calling grub_error. Also in all these contexts you handle the cases of unknown property name. I don't feel like refusing to load a theme because of unknown property is a good idea. This would i.a. exclude older GRUB versions for newer themes even if property in question is minor in meaning. Compare this to a browser refusing to show a page because of unknown tag attribute. Also GRUB_ERR_IO hardly describes a condition of unknown property. --------------enigBFB73D73372996C299F70312 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlE4QjUACgkQNak7dOguQglynQD/ap+E7M8pKYXae8WeLVx366Q2 BkQfTOTT1oJsYhFeYf4A/2SPeiQe2g3GQ1Gc2h4BP/V+PRsTKVkFxJCsdwCPQpXP =XO/4 -----END PGP SIGNATURE----- --------------enigBFB73D73372996C299F70312--