From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UDVvz-0002VV-Fg for mharc-grub-devel@gnu.org; Thu, 07 Mar 2013 03:12:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDVvv-0002UM-HL for grub-devel@gnu.org; Thu, 07 Mar 2013 03:12:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDVvs-0000rD-Qc for grub-devel@gnu.org; Thu, 07 Mar 2013 03:12:11 -0500 Received: from mail-wg0-f44.google.com ([74.125.82.44]:47381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDVvs-0000qx-H5 for grub-devel@gnu.org; Thu, 07 Mar 2013 03:12:08 -0500 Received: by mail-wg0-f44.google.com with SMTP id dr12so198153wgb.23 for ; Thu, 07 Mar 2013 00:12:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=/DmJ19EeimMo/y7Cx3HWhto4IrhC6HX43/XzXSgNis8=; b=jAi96p2pIffH2gensbODMRe0Wji1DVYXEYT6CRNrRb391gdIx3Z81P+1ZtOvyhPbDq nlzMXspKHh8+X3mOSNf8UOv0ZhVq2dQqFnAXStddgHSxXKPiZZd009ISQpRfQe61//Ew A1xXeQjxZ9HRERt67IG2SAGRSUDRu3HrZhOHNRBgzvco/43/6xLrLx5c8EsFUPCopNLD fEWsraQy+7s+Bv+cgPzKNnY9fWfE8XW4PB3av8dW41ngwlvhYQXAqJIPDMlRkoMxEJG9 cb8yK7Nawem/wwPosGqMILGrMV0l+PCbVwAaIrDfNeMxktelVCWKbr9a3/hI/SR4kT3d os+w== X-Received: by 10.180.183.81 with SMTP id ek17mr22971033wic.2.1362643927826; Thu, 07 Mar 2013 00:12:07 -0800 (PST) Received: from debian.x201.phnet ([217.193.148.98]) by mx.google.com with ESMTPS id j4sm31567048wiz.10.2013.03.07.00.12.06 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 07 Mar 2013 00:12:07 -0800 (PST) Message-ID: <51384BCF.3090308@gmail.com> Date: Thu, 07 Mar 2013 09:11:59 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] remove always_inline from fs/iso9660.c, caused gcc error References: <1362412867-29833-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1362412867-29833-1-git-send-email-arvidjaar@gmail.com> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig4F4C437A06DC9E13E70ABD67" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.82.44 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2013 08:12:14 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4F4C437A06DC9E13E70ABD67 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Committed, thanks. On 04.03.2013 17:01, Andrey Borzenkov wrote: > gcc -DHAVE_CONFIG_H -I. -Wall -W -I./include -DGRUB_UTIL=3D1 -DGRUB_L= IBDIR=3D\"/usr/local/lib64/grub\" -DLOCALEDIR=3D\"/usr/local/share/locale= \" -DGRUB_FILE=3D\"grub-core/fs/iso9660.c\" -I. -I. -I. -I. -I./include -= I./include -I./grub-core/lib/libgcrypt-grub/include -I./grub-core/lib/lib= gcrypt-grub/src/ -I./grub-core/lib/minilzo -I./grub-core/lib/xzembed -DM= INILZO_HAVE_CONFIG_H \ > -Wall -W -Wshadow -Wold-style-definition -Wpointer-arith = -Wundef -Wextra -Waddress -Wattributes -Wcast-align -Wchar-subscripts -Wc= omment -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -W= empty-body -Wendif-labels -Wfloat-equal -Wformat-extra-args -Wformat-secu= rity -Wformat-y2k -Wimplicit -Wimplicit-function-declaration -Wimplicit-i= nt -Winit-self -Wint-to-pointer-cast -Winvalid-pch -Wmain -Wmissing-brace= s -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noret= urn -Wmultichar -Wnonnull -Woverflow -Wparentheses -Wpointer-arith -Wpoin= ter-to-int-cast -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -W= strict-aliasing -Wswitch -Wtrigraphs -Wundef -Wunknown-pragmas -Wunused -= Wunused-function -Wunused-label -Wunused-parameter -Wunused-value -Wunus= ed-variable -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings -Wn= ested-externs -Wstrict-prototypes -Wpointer-sign -Werror -fno-builtin -W= no-undef -Wno-error=3Dmissing-noreturn \ > -MT grub-core/fs/libgrubmods_a-iso9660.o -MD -MP -MF grub-= core/fs/.deps-util/libgrubmods_a-iso9660.Tpo -c -o grub-core/fs/libgrubmo= ds_a-iso9660.o `test -f 'grub-core/fs/iso9660.c' || echo './'`grub-core/f= s/iso9660.c > grub-core/fs/iso9660.c:528:1: error: always_inline function might not b= e inlinable [-Werror=3Dattributes] > cc1: all warnings being treated as errors >=20 > bor@opensuse:~/build/grub> gcc --version > gcc (SUSE Linux) 4.7.1 20120723 [gcc-4_7-branch revision 189773] > Copyright (C) 2012 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is= NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURP= OSE. >=20 > Signed-off-by: Andrey Borzenkov >=20 > --- > ChangeLog | 5 +++++ > grub-core/fs/iso9660.c | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/ChangeLog b/ChangeLog > index cacba37..9cab5c7 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2013-03-04 Andrey Borzenkov > + > + * grub-core/fs/iso9660.c (add_part): Remove always_inline attribute > + causing gcc error with gcc 4.7.1. > + > 2013-03-03 Vladimir Serbinenko > =20 > Remove all trampoline support. Add -Wtrampolines when > diff --git a/grub-core/fs/iso9660.c b/grub-core/fs/iso9660.c > index 01a07b8..cdbd6dc 100644 > --- a/grub-core/fs/iso9660.c > +++ b/grub-core/fs/iso9660.c > @@ -524,7 +524,7 @@ struct iterate_dir_ctx > }; > =20 > /* Extend the symlink. */ > -static void __attribute__ ((always_inline)) > +static void > add_part (struct iterate_dir_ctx *ctx, > const char *part, > int len2) --------------enig4F4C437A06DC9E13E70ABD67 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlE4S88ACgkQNak7dOguQglJIQD/X/CX17ze0K8Yji9s+kBPSuAg YSYVyC24OAQXalvr2TYBAIkwrnPU7slCEdScvApKxd46Pk4wX+CHxPVwqBGrHOqy =NhSc -----END PGP SIGNATURE----- --------------enig4F4C437A06DC9E13E70ABD67--