From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] missed grub_free in icon_manager
Date: Thu, 07 Mar 2013 10:05:58 +0100 [thread overview]
Message-ID: <51385876.1080508@gmail.com> (raw)
In-Reply-To: <1572194.u8tUiaEOFG@icedphoenix>
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
On 07.03.2013 09:53, Vladimir Testov wrote:
> icondir = grub_env_get ("icondir");
> if (icondir)
> icon = try_loading_icon (mgr, icondir, class_name);
> + grub_free(icondir);
grub_env_get doesn't give you a personal copy but the common one. You
should not free it. In fact it should have been declared as returning
const char *.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2013-03-07 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 8:53 [PATCH] missed grub_free in icon_manager Vladimir Testov
2013-03-07 9:05 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-03-07 9:07 ` Vladimir 'φ-coder/phcoder' Serbinenko
-- strict thread matches above, loose matches on Subject: below --
2013-03-07 10:32 Vladimir Testov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51385876.1080508@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).