From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UDWmB-0002uY-6b for mharc-grub-devel@gnu.org; Thu, 07 Mar 2013 04:06:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDWm8-0002qz-CY for grub-devel@gnu.org; Thu, 07 Mar 2013 04:06:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDWm7-0002JA-6g for grub-devel@gnu.org; Thu, 07 Mar 2013 04:06:08 -0500 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:62211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDWm6-0002J5-WE for grub-devel@gnu.org; Thu, 07 Mar 2013 04:06:07 -0500 Received: by mail-wi0-f179.google.com with SMTP id ez12so91691wid.0 for ; Thu, 07 Mar 2013 01:06:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=QwfzshkOaPmNa4aYd3XCdUiIT80rEI/DoVgPYY4HcYk=; b=pFSSciFYgKlqGdCxa2ImII0hf8ebngX6Mmkn4VZrWnfTK/mzf/+fqqU9q+RuMWJ250 idqhdAJ20Z3BFuNnOx+m/Sms7yGpphVFhg8bkdWUKjGHbBuAYh/mGGNWFiBph/aW1w5H RLUo8Dm5/fAEscoGVDQeboOGzbHqAz/J/6pmnyLEbUiwKOThFkVHJbMBhoR/5jp7FNu6 MQHn69xmZQjNwuRL2SswEoxu83iHNRN4mBmff038Shd6m8xZHEnUlCbRi1NkeHcykbGe a8i4gz3E5ZtYkR0VBFkpdCxEK4kHoRZNZpcaluVtWWHrr4IiFCrnVIl2Erss34HzFHep IiRw== X-Received: by 10.180.85.97 with SMTP id g1mr31796725wiz.29.1362647166236; Thu, 07 Mar 2013 01:06:06 -0800 (PST) Received: from debian.x201.phnet ([217.193.148.98]) by mx.google.com with ESMTPS id ek4sm31859810wib.11.2013.03.07.01.06.04 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 07 Mar 2013 01:06:05 -0800 (PST) Message-ID: <51385876.1080508@gmail.com> Date: Thu, 07 Mar 2013 10:05:58 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] missed grub_free in icon_manager References: <1572194.u8tUiaEOFG@icedphoenix> In-Reply-To: <1572194.u8tUiaEOFG@icedphoenix> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigFD41887C80363C0A679F629B" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::233 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2013 09:06:09 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFD41887C80363C0A679F629B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07.03.2013 09:53, Vladimir Testov wrote: > icondir =3D grub_env_get ("icondir"); > if (icondir) > icon =3D try_loading_icon (mgr, icondir, class_name); > + grub_free(icondir); grub_env_get doesn't give you a personal copy but the common one. You should not free it. In fact it should have been declared as returning const char *. --------------enigFD41887C80363C0A679F629B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF0EAREKAAYFAlE4WHYACgkQNak7dOguQgm86wD2ODk1oVBE/+GfNxvc0NZxi924 vVZlobqrTccEWxcbfQEAnzcKpBEh6I4QzH4Patb1Dh+vR0bR59gvGx+Uiuk9lCA= =5iTF -----END PGP SIGNATURE----- --------------enigFD41887C80363C0A679F629B--