From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UDWnz-0004S1-9I for mharc-grub-devel@gnu.org; Thu, 07 Mar 2013 04:08:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDWnv-0004Ny-Nr for grub-devel@gnu.org; Thu, 07 Mar 2013 04:08:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDWnu-0002cn-Hl for grub-devel@gnu.org; Thu, 07 Mar 2013 04:07:59 -0500 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:63869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDWnu-0002cg-BA for grub-devel@gnu.org; Thu, 07 Mar 2013 04:07:58 -0500 Received: by mail-wi0-f172.google.com with SMTP id ez12so607739wid.11 for ; Thu, 07 Mar 2013 01:07:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=jNli+UNXb0k8d9c/dLMmtX0mZpufIGiSYxdvLnDU4qs=; b=ZtPAUGuM04LhiiiGTDgUiGkLsjjUOoSAgD/vrHRN6RGTcbTuCwTVm0kA55pm0EoZy8 KpM6YRREx4W/YKTKVRJ5X206yZJhk0JMeEQTZ42Z1902T01ToJwfgkPp2pynLDUMt8q4 7WIhsOLDKoozHmEhpWe7gj5DpllQHpsmLdSb+2625EOGOkeev33qV3z/otzQxo2gzh9f YdkwN5GkTs/QWa4i+WX6CEDNr6fSEVC/PmxGklubrs4JjziCEnhHblM9/D+ewTU12dGY t8UJhCvUOou78zGiaB9k64xAbjz8tOWVRzZ5Q4G8ydthRXwAlEsHEOHEfOG4vB6jT8Nm HLsw== X-Received: by 10.180.38.101 with SMTP id f5mr1708788wik.25.1362647277698; Thu, 07 Mar 2013 01:07:57 -0800 (PST) Received: from debian.x201.phnet ([217.193.148.98]) by mx.google.com with ESMTPS id fv2sm1415779wib.6.2013.03.07.01.07.56 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 07 Mar 2013 01:07:57 -0800 (PST) Message-ID: <513858E6.4030105@gmail.com> Date: Thu, 07 Mar 2013 10:07:50 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] missed grub_free in icon_manager References: <1572194.u8tUiaEOFG@icedphoenix> <51385876.1080508@gmail.com> In-Reply-To: <51385876.1080508@gmail.com> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigAC6FA78AECA4CB74204CAB5C" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2013 09:08:01 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAC6FA78AECA4CB74204CAB5C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07.03.2013 10:05, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: > On 07.03.2013 09:53, Vladimir Testov wrote: >=20 >> icondir =3D grub_env_get ("icondir"); >> if (icondir) >> icon =3D try_loading_icon (mgr, icondir, class_name); >> + grub_free(icondir); >=20 > grub_env_get doesn't give you a personal copy but the common one. You > should not free it. In fact it should have been declared as returning > const char *. >=20 And actually it is. Did you disable warnings and/or -Werror? As this shouldn't even compile. --------------enigAC6FA78AECA4CB74204CAB5C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlE4WOYACgkQNak7dOguQgnS/QEAow94CvJGs4fZLMPkLOn2o/7t f+bVYHtlSMKg3TBi/zEBAItTM7MstFNu1vNloQUacCi2q+qaZJ+o/Dy/uHke8W7d =yr/k -----END PGP SIGNATURE----- --------------enigAC6FA78AECA4CB74204CAB5C--