From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [4/4] [PATCH] incorrect calculation of radius in circular_progress.
Date: Tue, 19 Mar 2013 07:55:16 +0100 [thread overview]
Message-ID: <51480BD4.8050507@gmail.com> (raw)
In-Reply-To: <8469205.Z2B8CHPVqt@icedphoenix>
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
On 13.03.2013 11:53, Vladimir Testov wrote:
> + int min = width;
> + if (height < min) {
> + min = height;
> + }
Please avoid using variables like max/min which can easily conflict with
macros defined on some systems
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2013-03-19 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 10:53 [4/4] [PATCH] incorrect calculation of radius in circular_progress Vladimir Testov
2013-03-19 6:55 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-20 7:43 Vladimir Testov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51480BD4.8050507@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).