grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities
Date: Tue, 19 Mar 2013 08:01:46 +0100	[thread overview]
Message-ID: <51480D5A.7010705@gmail.com> (raw)
In-Reply-To: <20130315175655.GC1271@csclub.uwaterloo.ca>

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

On 15.03.2013 18:56, Lennart Sorensen wrote:

> On Fri, Mar 15, 2013 at 08:52:08PM +0400, Andrey Borzenkov wrote:
>> В Wed, 13 Mar 2013 14:52:13 +0400
>> Vladimir Testov <vladimir.testov@rosalab.ru> пишет:
>>
>>> In current state, start angle is measured in "parrots", where 1 "parrot" = 1 / 
>>> 256 of full circle.
>>>
>>> With simple patch we can set start angle in degrees (which makes no difference 
>>> for the program, but makes configuration to be more user-friendly)
>>>
>>
>> This has compatibility issue and probably cannot be done without
>> introducing theme file format version.
>>
>> What about adding new parameter name instead (although start_angle_angle
>> looks rather silly)?
> 
> start_angle_degrees?
> 
> Could have start_angle_radians too (although it would need floating
> point to be useful).

GRUB doesn't use floats at all as it would decrease compatibility and
brings nothing useful to us.

> 
> Could even have start_angle_gradians
> 

This would be featuritus



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

  reply	other threads:[~2013-03-19  7:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 10:52 [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities Vladimir Testov
2013-03-15 16:52 ` Andrey Borzenkov
2013-03-15 17:56   ` Lennart Sorensen
2013-03-19  7:01     ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-03-19  7:00   ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-03-19  6:57 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-11 15:48 ` Vladimir Testov
2013-04-11 15:56   ` Andrey Borzenkov
2013-04-11 16:00   ` Vladimir Testov
  -- strict thread matches above, loose matches on Subject: below --
2013-04-12  7:27 Vladimir Testov
2013-04-19 14:16 ` Andrey Borzenkov
2013-04-23 10:22   ` Vladimir Testov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51480D5A.7010705@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).