From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UMSAQ-00034y-8r for mharc-grub-devel@gnu.org; Sun, 31 Mar 2013 20:00:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMSAM-00032l-KL for grub-devel@gnu.org; Sun, 31 Mar 2013 20:00:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMSAK-0003XG-TO for grub-devel@gnu.org; Sun, 31 Mar 2013 20:00:02 -0400 Received: from mail-ee0-f49.google.com ([74.125.83.49]:64912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMSAK-0003X2-M1 for grub-devel@gnu.org; Sun, 31 Mar 2013 20:00:00 -0400 Received: by mail-ee0-f49.google.com with SMTP id d41so839008eek.8 for ; Sun, 31 Mar 2013 16:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=JaJqY5pyNALlP40ECD/Zk2+6pDi3zoSoN2mC2/YkBcU=; b=sZYXD75LAyW/OV2S25Rs9+6/g1NpPyX/5KfRHQXFJYuTF3W5Ah8daWULwDS4Bl9yr0 hQt4Ar/aIqX7QtaEfQQ7Utj+AJl5U8ggiTzxSGilnTg9CADRkLpGv7awrqe5pQVMV1dI AOWxSS63N+vt+d+Hx+ecHAXa4wIeSJ+A2rmy8aBXrEL5adrCs/Ah7emF33QnJRLfgx5O HCO1HQ+5PhFLVYGziPiJ5aAzojFQeRkZnmSd8pf5+SiP/zdJOB2UAKaVU0wNE0bI8ICg NeeOT2t7kTjXwxU53olsZoOqS0X4CUIN/JDyTTg1ytCLfHyafjxR6TLdxeMcN9c560yp 2oBg== X-Received: by 10.14.182.137 with SMTP id o9mr31693994eem.13.1364774398927; Sun, 31 Mar 2013 16:59:58 -0700 (PDT) Received: from debian.x201.phnet (245-188.1-85.cust.bluewin.ch. [85.1.188.245]) by mx.google.com with ESMTPS id u44sm18227036eel.7.2013.03.31.16.59.57 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 31 Mar 2013 16:59:58 -0700 (PDT) Message-ID: <5158CDFC.8060302@gmail.com> Date: Mon, 01 Apr 2013 01:59:56 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] reset LC_MESSAGES to C too References: <1364633104-20097-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1364633104-20097-1-git-send-email-arvidjaar@gmail.com> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig91C936E63972151FF7162816" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.83.49 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 00:00:05 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig91C936E63972151FF7162816 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 30.03.2013 09:45, Andrey Borzenkov wrote: > If user locale has non-ASCII translation strings, running grub make > outputs only question marks: >=20 > bor@opensuse:~/build/grub> locale > LANG=3Dru_RU.utf8 > LC_CTYPE=3D"ru_RU.utf8" > LC_NUMERIC=3D"ru_RU.utf8" > LC_TIME=3D"ru_RU.utf8" > LC_COLLATE=3D"ru_RU.utf8" > LC_MONETARY=3D"ru_RU.utf8" > LC_MESSAGES=3D"ru_RU.utf8" > LC_PAPER=3D"ru_RU.utf8" > LC_NAME=3D"ru_RU.utf8" > LC_ADDRESS=3D"ru_RU.utf8" > LC_TELEPHONE=3D"ru_RU.utf8" > LC_MEASUREMENT=3D"ru_RU.utf8" > LC_IDENTIFICATION=3D"ru_RU.utf8" > LC_ALL=3D >=20 > make[2]: ????? ?? ???????? `/home/bor/build/grub/docs' > Making all in util/bash-completion.d > make[2]: ???? ? ??????? `/home/bor/build/grub/util/bash-completion.d' > make[2]: ???? `all' ?? ??????? ?????????? ??????. > make[2]: ????? ?? ???????? `/home/bor/build/grub/util/bash-completion.d= ' > make[1]: ????? ?? ???????? `/home/bor/build/grub' >=20 > The reason is, grub Makefile resets LC_CTYPE to C. This makes it > impossible to translate messages into current locale (C at the time > tools are running). Reset LC_MESSAGES to C as well, it is better to > have them in English than do not have them at all. This doesn't seem right thing to do. LC_COLLATE was reset to C because of Estonian since [a-z] in Estonian doesn't include u or t. LC_CTYPE might break e.g. [[:alpha:]]. But I don't know how to stop it from interfering with make and gcc messages >=20 > Problem observed on Linux with glibc 2.17 and 2.15. >=20 > Signed-off-by: Andrey Borzenkov >=20 > --- > ChangeLog | 5 +++++ > conf/Makefile.common | 1 + > 2 files changed, 6 insertions(+) >=20 > diff --git a/ChangeLog b/ChangeLog > index 58c2242..cd1f762 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2013-03-30 Andrey Borzenkov > + > + * conf/Makefile.common: Reset LC_MESSAGES to C too to avoid > + question marks in messages during build on non-ASCII locale. > + > 2013-03-26 Vladimir Serbinenko > =20 > * grub-core/kern/efi/mm.c (grub_efi_finish_boot_services): > diff --git a/conf/Makefile.common b/conf/Makefile.common > index c185a55..f49581d 100644 > --- a/conf/Makefile.common > +++ b/conf/Makefile.common > @@ -4,6 +4,7 @@ CFLAGS_PLATFORM=3D > =20 > export LC_COLLATE :=3D C > export LC_CTYPE :=3D C > +export LC_MESSAGES :=3D C > unexport LC_ALL > =20 > # Platform specific options --------------enig91C936E63972151FF7162816 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlFYzfwACgkQNak7dOguQgnyOQEAw5Dh34UisndSMKQV6S3hNBoU FVhaXf0ru5JkKyRu7G4BAJFkXxjUTTp2F6CTCvhY7jKTxXl+VplE18eP3zL5/nA4 =o0sq -----END PGP SIGNATURE----- --------------enig91C936E63972151FF7162816--