From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UMcqK-0005OQ-Fa for mharc-grub-devel@gnu.org; Mon, 01 Apr 2013 07:24:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMcqD-0005KW-Pw for grub-devel@gnu.org; Mon, 01 Apr 2013 07:24:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMcq6-0003HS-9R for grub-devel@gnu.org; Mon, 01 Apr 2013 07:23:57 -0400 Received: from mail-ee0-f47.google.com ([74.125.83.47]:51951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMcq6-0003HK-33 for grub-devel@gnu.org; Mon, 01 Apr 2013 07:23:50 -0400 Received: by mail-ee0-f47.google.com with SMTP id t10so987372eei.20 for ; Mon, 01 Apr 2013 04:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=J2TaiYaFhdF2t9YT/t9VrpzHUMOEnNKBj0VBF1Ia/HE=; b=ECdbGnE8XyVR3my+18EIydhhIPbO4rg05C8tYhu2KYnUB7MXch+E4zibRKCXC/nx51 wFb2bMhiqI1AyOf1H/A7/B7xok27MxJ/BpMT1Vm2d6owvRbFCdvSu+u+It+Yrlv2wimT Dpc5dnZrynuruHn5qh5EoQxbZ3ixxPJfcA00Qd/MlF6p1YYGVX7ABFrsY26WdMCmB8LU gMFOZrY99QpHPsdJ+3ydkCqitwCsU0wbdDJTNTe/3+3ew5Z94kBdIgPVQ1UIHsTOLqkV wIoko6GRvVh6OnlA3ez7nFECkZHaRqP48nFrlya31BICqm08UH1SR9f+RSI9RKsv3esX q4fA== X-Received: by 10.14.183.198 with SMTP id q46mr37006466eem.1.1364815429397; Mon, 01 Apr 2013 04:23:49 -0700 (PDT) Received: from debian.x201.phnet (245-188.1-85.cust.bluewin.ch. [85.1.188.245]) by mx.google.com with ESMTPS id q42sm20504311eem.14.2013.04.01.04.23.48 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 01 Apr 2013 04:23:48 -0700 (PDT) Message-ID: <51596E28.2030702@gmail.com> Date: Mon, 01 Apr 2013 13:23:20 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms References: <5158F171.6030702@gmail.com> <51596446.3030709@gmail.com> In-Reply-To: <51596446.3030709@gmail.com> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigF8FF5CD1DFB56887D457FEE2" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.83.47 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 11:24:03 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF8FF5CD1DFB56887D457FEE2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable > > How would you handle such a case? I guess a machine which can't provide= > this runtime service would need some more work in its EFI firmware > before being ready for GRUB, so perhaps this is a moot point. >=20 If no timing is available, you'd need at least return a count of calls to the get_time function. > I propose to re-use the existing function grub_datetime2unixtime() > (which handles correctly the number of days of each month, as well as > leap years), instead of doing the calculations here. And take into > account the time_zone member of grub_efi_time_t as well. get_time is wrong function for getting tsc. You should create a timer event with 10000 units (=3D1 ms) and in its callback increase millisecond= counter. > Also, there is nothing ARM-specific in this function, so I would put it= > in a generic EFI file like kern/efi/efi.c. >=20 it is ARM-specific by exclusion. All other EFI ports have TSC and don't need to use EFI functions to retrieve it (other than for calibration on ia64) --------------enigF8FF5CD1DFB56887D457FEE2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlFZbkMACgkQNak7dOguQgkQagD/TO6J+69qPu88R0nnsqghsdmF kiTLmHxhrIgWzECohh8BAKE3QfEm3+e/N3pfUesYcNFKCudFhYN7WrlbYVOEXsOk =DTqI -----END PGP SIGNATURE----- --------------enigF8FF5CD1DFB56887D457FEE2--